Changes

Jump to: navigation, search

User:Egmetcalfe/Dead Code

3,081 bytes added, 23:09, 25 March 2010
no edit summary
===layout/generic===
 
====void nsFrameList::SortByContentOrder()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=SortByContentOrder MXR Search] (This will take an nsTArray::Sort along with it too)
 
Code Size: 35
====nsIFrame* nsBlockFrame::GetTopBlockChild(nsPresContext*)====
[http://mxr.mozilla.org/mozilla-central/search?string=FindLineAt MXR Search]
 
====nsLineBox* nsLineBox::FindLineContaining(nsLineList&,nsIFrame*,PRInt32*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=FindLineContaining MXR Search]
 
Code Size: 18
 
====PRBool nsFrameList::ContainsFrameBefore(const nsIFrame*,const nsIFrame*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=ContainsFrameBefore MXR Search]
 
Code Size: 10
 
====nsFramesetDrag::nsFramesetDrag(PRBool,PRInt32,PRInt32,nsHTMLFramesetFrame*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=nsFramesetDrag MXR Search]
 
Code Size: 6
 
====void Area::GetHREF(nsAString_internal&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetHREF MXR Search] (Pain to check but dead. Note that it's non-virtual from a non-derived class)
 
Code Size: 3
====nsRect nsIFrame::GetMarginRect()====
[http://mxr.mozilla.org/mozilla-central/search?string=GetMarginRect MXR Search]
Code Size: 1011
====PRBool nsIntervalSet::HasPoint(nscoord)====
Code Size: 10
 
====nsresult nsIFrame::Clip(nsDisplayListBuilder*,const nsDisplayListSet&,const nsDisplayListSet&,const nsRect&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=%5B%5Ea-z%5DClip%5C%2528%5B%5E%2529%5D&regexp=1&case=1 MXR Search]
 
Code Size: 4
 
====nsRect nsIFrame::GetScreenRectInAppUnitsExternal()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetScreenRectInAppUnitsExternal MXR Search]
 
Code Size: 3
 
====void* nsIFrame::GetPropertyExternal(nsIAtom*,nsresult*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetPropertyExternal MXR Search]
 
Code Size: 3
===layout/tables===
Code Size: 0 (pure virtual)
 
===layout/inspector===
 
====void inSearchLoop::inSearchLoop(inISearchProcess*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=inSearchLoop MXR Search] (This'll take an nsCOMPtr::operator= along with it)
 
Code Size: 11
 
*** Upon further examination, the whole layout/inspector module seems unused. All of the classes from [http://mxr.mozilla.org/mozilla-central/source/layout/inspector/src/Makefile.in#52 these files] end up in an NS_GENERIC_FACTORY_CONSTRUCTOR (except inSearchLoop). The Makefile also claims "This library is used by other shared libs in a static build". Reading [https://developer.mozilla.org/en/DOM_Inspector/Introduction_to_DOM_Inspector this mdc page], this is apparently used for the DOM Inspector, but does it/should it make its way into libxul?
 
===xpcom/components===
 
Don't know if this stuff can be touched
 
====nsresult nsServiceManager::GetGlobalServiceManager(nsIServiceManager**)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetGlobalServiceManager MXR Search]
 
Code Size: 15
 
====nsresult nsServiceManager::ShutdownGlobalServiceManager(nsIServiceManager**)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=ShutdownGlobalServiceManager MXR Search]
 
Code Size: 2
 
===xpcom/base===
 
===nsresult nsTraceRefcntImpl::LogAddRef(void*,nsrefcnt,const char*,PRUint32) et al===
 
6 of the functions of this class are dead but the [http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsITraceRefcnt.idl#43 idl file] lists its status as frozen (and deprecated).
== Bugs/Strangeness ==
1
edit

Navigation menu