Changes

Jump to: navigation, search

Implementing the Mouse Lock API in Firefox

13 bytes added, 22:24, 15 December 2011
Review Issues
* "nsDOMMouseLockable::ShouldLock...QI to nsINode and check IsInDoc()"
* "nsRefPtr<nsMouseLockableRequest> request = new nsMouseLockableRequest(aSuccessCallback, aFailureCallback); -- You should store aTarget (QI'ed to nsINode or nsIContent or Element or nsIDOMEventTarget) so that when calling callback you push Cx to stack; nsCxPusher pusher: // defined in nsContentUtils.h NS_ENSURE_STATE(pusher.Push(target));"
* <s>"nsDOMMouseLockable looks like it should be cycle collectable"</s> humph
* Break .pointer out of Navigator, and add nsIDOMMozNavigatorPointer (not sure if this name is best) as a new interface to Navigator, similar to nsIDOMMozNavigatorBattery.
* Rename for moz* prefix. The API should be probably prefixed. So, navigator.mozPointer and all the interfaces should start with nsIDOMMoz. Similar to what webkit* is doing:

Navigation menu