Changes

# {| border=1 style="border: 1px solid darkgray;"|Id|Description|Test Author(s)|Test File|-|1|<s>"there is no limit to how far movement can go...not limited by screen boundaries" -- mouse lock should mean infinite movement in the X and Y axes...There will be no limit to movementX/Y values if the mouse is continuously moved in a single direction"</s> - |'''hchun'''# <|'''file_limitlessScroll.html'''|-|2|<s>"The concept of the mouse cursor will have been removed, and it will not move off the window or be clamped by a screen edge"</s> - |'''hchun'''# |'''file_limitlessScroll.html'''|-|3|"no mouse cursor is displayed" -- mouse cursor should be hidden while locked - |'''dvillase'''# |-|4|<s>navigator.pointer (readonly) is a MouseLockable</s> - |<strong>abhatnagar</strong># |'''test_navigatorPointer.html'''|-|5|<s>MouseLockable has lock(), unlock(), islocked()</s> - |<strong>abhatnagar</strong># <s|'''test_mouseLockableHasRequiredMethods.html'''|-|6|<s>islocked() returns true if mouse is locked, false if not locked</s> - |<strong>JSilver999</strong># |'''file_fullscreen.html'''|-|7|<s>lock(target) expects a DOM element, and takes two optional callbacks: successcallback, failurecallback.</s> - |<strong>JSilver999</strong># |'''file_fullscreen.html'''|-|8|<s>lock() should return immediately and call callbacks when lock succeeds or fails</s> - |<strong>JSilver999</strong># <s>"Mouse |'''file_fullscreen.html'''|-|9|"Mouse lock must succeed only if the window is in focus" - |'''johnno'''</s># <s>||-|10|"Mouse lock must succeed only if...the user-agent is the active application of the operating system"</s> - ''|'''johnno'''# ||-|11|<s>"The target of lock need not be in focus" - </s>|'''johnno'''</s># <s|'''file_targetOutOfFocus.html'''|-|12|<s>"Mouse lock must succeed only if the target is in the DOM tree"</s> - |'''Anachid'''# |'''file_DOMtree.html'''|-|13|<s>"If the target is removed from the DOM tree after mouse lock is entered then mouse lock will be lost."</s> - |'''Anachid'''# |'''file_DOMtree.html'''|-|14|<s>"If the mouse is already locked to the same element, a repeated call to lock will succeed and the successCallback called"</s> - |'''jboelen'''# |'''test_doubleLockCallBack.html'''|-|15|<s>"If another element is locked [and lock() is called] a user agent must transfer the mouse lock to the new target and call the mouselocklost callback for the previous target"</s> - |'''jboelen'''# |'''DEFUNCT'''|-|16|<s>"The Mouse Lock API must provide a default system action to unlock the mouse" namely ESC.</s> - |'''CloudScorpianCloudScorpion'''# <s>"|'''file_defaultUnlock.html'''|-|17|<s>"Once in the locked state the user agent must fire all relevant user generated MouseEvent events (for example: mousemove, mousedown, mouseup, click, wheel)[DOM-LEVEL-3-CORE] to the target of mouse lock, and not fire mouse events to other elements"</s> - |'''rhung'''# |'''file_MouseEvents.html'''|-|18|<s>"Events that require the concept of a mouse cursor must not be dispatched (for example: mouseover, mouseout)"</s> - |'''rhung'''# |'''file_MouseEvents.html'''|-|19|"Movement and button presses of the mouse must not cause the window to lose focus" - # |-|20|<s>"Synthetic mouse events created by application script act the same regardless of lock state"</s> - |'''Tentacle'''# <s>|'''file_syntheticMouseEvent.html'''|-|21|<s>"The unlock method cancels the mouse lock state"</s> - |'''abhatnagar1'''# |No test written for this case specifically but '''file_fullscreen.html''' covers it.|-|22|"[Upon unlock() t]he system mouse cursor must be displayed again and positioned at the same location that it was when mouse lock was entered (the same location that is reported in screenX/Y when the mouse is locked)" - |'''dvillase'''# |-|23|<s>"When mouse lock is lost or disabled for any reason user agents must fire an event named mouselocklost with its bubble attribute set to true to the mouse lock target element"</s> - |'''stsang'''# |'''file_mouselocklost.html'''|-|24|<s>MouseEvent must contain (readonly) movementX and movementY</s> - |'''KeyR, JSilver999'''# <|'''file_movement.html'''|-|25|<s>"The members movementX and movementY must provide the change in position of the mouse, as if the values of screenX/Y were stored between two subsequent mousemove events eNow and ePrevious and the difference taken movementX = eNow.screenX-ePrevious.screenX"</s> - |'''KeyR, JSilver999'''# |'''file_movement.html'''|-|26|<s>"movementX/Y must be valid regardless of mouse lock state"</s> - |'''KeyR, JSilver999'''# |'''file_movement.html'''|-|27|<s>"When unlocked, the system cursor can exit and re-enter the user agent window. If it does so and the user agent was not the target of operating system mouse move events then the most recent mouse position will be unknown to the user agent and movementX/Y can not be computed and must be set to zero"</s> - |'''moussa1'''# |'''test_mousePos.html'''|-|28|<s>"When mouse lock is enabled clientX, clientY, screenX, and screenY must hold constant values as if the mouse did not move at all once mouse lock was entered"</s> - |'''jbraffoul'''# |'''file_constantxy.html'''|-|29|<s>"The Mouse Lock API must exit the mouse lock state if the user agent, window, or tab loses focus"</s> - |'''drigato'''# Test to make sure |'''test_exitMouselockOnLoseFocus.html'''|-|30|Test to make sure that mouse lock only occurs when an element is in full screen mode (not F11 or done via the menus). This includes:## Switching focus to another window - |'''jsiu3'''# |-|31|<s>Tests for mouselocklost event</s> - |'''stsang'''|'''file_mouselocklost.html'''|-|32|<s>Test to make sure that mouse is unlocked when page is unloaded.</s>|'''northWind'''|'''file_unlockOnUnload.html'''|-|}

=====Reviewing Tests=====

====New Test Reviews[Updated 1/19/2012]====This is a new list of test. The following tests will need to confirm to the new prefixes in accordance to Patchv3 of [https://bugzilla.mozilla.org/show_bug.cgi?id=633602 Bug 633602]. Please add your name beside each test(s) you are assessing/reviewing/fixing/peer reviewing.Once the cause for rejection is clear, indicate it by placing an X in any of the columns and optionally filling out the comments column. Indicate the action taken to resolve the issue in the action taken column. Example actions include:# '''DELETED'''# '''FIXED''' Other actions are also acceptable where appropriate.Once fixed, please pull request to rhung's [https://github.com/rhung/mozilla-central/tree/mouselock-tests/dom/tests/mochitest/mouselockrhung's mouselock-tests] branch and indicate that you've done so in the pull requested column. Ensure that you add '''[POST-SUBMIT]''' to the name of your pull request. {| border=1 style="border: 1px solid darkgray;"| Num| Name| Primary Reviewer| Timing issues?| Needs Harness?| Needs focus?| Formatting issues?| Other? (Indicate in comments)| Peer Reviewers| Peer reviewed?| Action Taken| Pull requested?| bgcolor="red" style="text-align:center;" | Updated with Patchv3 | Comments|- | colspan=14 bgcolor="yellow" style="text-align:center;" | '''Ensure you have actually tested your test before sending a pull request'''|-| 1| test_FullScreenHarness.html| Anachid| X (no action)| X (no action)| X (no action)| X (no action)| -| | | '''FIXED'''| | X| |-| 2| file_DOMtree.html| Anachid| X (fixed)| X (fixed)| X (fixed)| X (no action)| -| | | '''FIXED''' | | X| |-| 3| file_nestedFullScreen.html| Anachid| X (fixed)| X (fixed)| X (fixed)| X (no action)| -| | | '''FIXED''' | | X| |-| 4| file_differentDOM.html| Anachid| X (no action)| X (no action)| X (no action)| X (no action)| -| | | '''FIXED''' | | X| |-| 5| file_fullscreen.html| Anachid| X| X| X| X| -| | | '''FIXED''' | | X| Test needs to completely re-done. Cases like <br>* ok(false, "Mouse locked without fullscreen mode"); will always fail!* Flow of the test will causes scope problems.* Currently fixing.|-| 6| file_doubleLockCallBack.html| Anachid| X| X| X| X| -| | | '''FIXED''' | | X| |-| 7| file_unlockOnUnload.html| Anachid| X| X| X| X| -| | | '''FIXED''' | | X| |-| 8| file_exitMouseLockOnLoseFocus.html| Anachid| X| X| X| X| -| | | '''FIXED''' | | X| |-| 9| test_mousePos.html| rhung||||| Doesn't seem like it can be done via mochitest||| '''REMOVED'''||| As mentioned in the previous comments, synthesizeMouse cannot be moved beyond the browser. It might need to be a litmus test.|-| 10| file_mouselocklost.html| Anachid| X| X| X| X| -| | | '''FIXED''' | | X| Removed some test that were repeating. Otherwise, it works|-| 11| file_movementXY.html| rhung| X| X| X| X| -| | | '''Fixing''' | | X||-| 12| file_targetOutOfFocus.html| rhung| X| X| X| X (fixed)| -| | | '''FIXED''' | | X| Minor changes, mostly styling.|-| 13| test_mouseLockable.html| rhung| X| X| X| X| -| | | '''FIXED & RENAMED''' | | X| Updated to test_MozPointerLock.html|-| 14| file_MouseEvents.html| rhung| X| X| X| X| Leak issue might be platform specific.| | | '''FIXED?''' | | X| Works without chance of hanging or random success and failures.|-| 15| file_limitlessScroll.html| rhung|||||| | | '''MERGED WITH file_movementXY''' | |||-| 16| file_defaultUnlock.html| rhung|||||| | | '''FIXED''' | | X||-| 17| file_userPref.html| rhung|||||| | | '''FIXED''' || X||-| 18| file_constantXY.html| rhung|||||| | | '''FIXING''' || X| Needs proper error messages, perhaps formatting issues. Test runs fine though.|-|}  New Tests (not sure if it will work on mochitest, and the test will possibly fail as dave is working on this patch)# When there is a parent element with multiple child element, have a test to check that all mouse events fired inside the child element are suppressed and is captured by the parent element. (this may also include the scenario where there is an iframe in the parent element)# A Test to check that repeated move of the mouse to a certain direction that will exceed the screen size does not break the mouselock (this may conflict with file_movementXY.html and we may need to add more test cases) ====Changes To Be Applied To Submitted Tests [Deprecated]==== The following table is used to maintain a small note on the task for each test. It will include note from the review by Mozilla and issue we overlooked.  {| border=1 style="border: 1px solid darkgray;"| Num| Test Name| Reviewer| Notes|- | colspan=4 bgcolor="yellow" style="text-align:center;" | '''Please add your name to the section you want to review and fix'''|-|- | colspan=8 bgcolor="lightgreen" style="text-align:center;" | '''Fill out the Notes section for any issues that are outstanding'''|-|1|test_DOMtree.html||* northWind Comments:** Should Delete the element from DOM without exiting fullscreen and then check for pointer.lock instead of the current flow.|-|2|test_MouseEvents.html||* rhung Comments:** Should move the tests that require mouselock into the success callback of the lock function.** Figure out why mouseleave and mouseout tests don't work for Macs.|-|3||||-|} ====Remaining Test Reviews [Deprecated]====The following tests need investigation. Please add your name beside each test(s) you are assessing/reviewing/fixing/peer reviewing.Once the cause for rejection is clear, indicate it by placing an X in any of the columns and optionally filling out the comments column. Indicate the action taken to resolve the issue in the action taken column. Example actions include:# '''DELETED'''# '''FIXED''' Other actions are also acceptable where appropriate.Once fixed, please pull request to rhung's [https://github.com/rhung/mozilla-central/tree/mouselock-tests/dom/tests/mochitest/mouselockrhung's mouselock-tests] branch and indicate that you've done so in the pull requested column. Ensure that you add '''[POST-SUBMIT]''' to the name of your pull request. {| border=1 style="border: 1px solid darkgray;"| Num| Name| Primary Reviewer| Timing issues?| Needs Harness?| Needs focus?| Formatting issues?| Other? (Indicate in comments)| Peer Reviewers| Peer reviewed?| Action Taken| Pull requested?| bgcolor="red" style="text-align:center;" | Updated with Patchv3 | Comments|- | colspan=14 bgcolor="yellow" style="text-align:center;" | '''Ensure you have actually tested your test before sending a pull request'''|-|-|<s>106</s>|<s>test_UserAgentIsActive</s>|<s>diogogmt</s>||<s>X</s>||<s>X</s>|<s>X</s>|<s>northwind</s>||<s><b>IMPOSSIBLE IN MOCHITEST</b></s>|||<s>* northWind Comments prior to diogo re-writing user agent test:** navigator.userAgent does not indicate focus status of browser.** test should be testing for full screen if user agent is in focus then testing that full screen is unavailable when user agent is not in focus.** test uses tabs, should use spaces.</s>|-|<s>109</s>|<s>file_doubleLockCallBack.html</s>|<s>northWind</s>||X|X|X||<s>rhung</s>|X|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>|X||* <s>For Peer Reviewer: https://github.com/rhung/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/mouselock/file_doubleLockCallBack.html</s>|-|<s>110</s>|<s>test_exitMouselockOnLoseFocus.html</s>|<s>diogogmt</s>||<s>X</s>|<s>X</s>|<s>X</s>||<s>northWind</s>|<s>X</s>|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>||||-|114|test_mousePos.html|diogogmt|||||||||||A summary of the test: *Move the mouse outside the browser boundaries. *Move the mouse back inside the browser. *Checks if movementXY were set to zero, since the last refPoint is unknownThe problem is that synthesizeMouse doesn't move the mouse outside the boundaries of the specified element. If the X/Y coords passed to synthesizeMouse are bigger than the X/Y of the element receiving the event, it won't move the cursor. I'm logging all the screen/client/movementXY values, and if the coords passed to synthesizeMouse are bigger than the boundaries of the element receiving the mousemove, the test will break, since the mouse is never moved.   [http://pastebin.com/MhP62BtC code]   |-|<s>115</s>|<s>file_mouselocklost.html</s>|<s>diogogmt</s>||||||<s>rhung</s>||<s><b>PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>|||<s>Original file didn't need any changes. Passed all test criterias</s><s>Awaiting peer review to cross it off the list</s>|-|<s>119</s>|<s>file_fullscreen.html</s>|<s>northWind</s>|<s>X</s>|<s>X</s>|<s>X</s>|<s>X</s>|<s>X</s>|<s>rhung</s>||<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>|X||<s>Lines</s> <s>49</s>, <s>66</s><s>, and 76 are too long. 76 in particular.</s> <s>Needs comment at the beginning to describe what the test does.</s>|-|<s>107</s>|<s>file_screenXYclientXYConst.html</s>|<s>diogogmt</s>|<s>X</s>|<s>X</s>||||<s>anachid</s>||<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>|||<s>[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests-constantXY/dom/tests/mochitest/mouselock/file_constantXY.html file_constantXY]</s><s>[https://github.com/diogogmt/mozilla-central/tree/mouselock-tests-constantXY branch]</s> <s>* Anachid (formatting review on file commit version '''1f5fa3e0a5f7730f33eb5d3f7c51105fac4cb93d'''):</s><s>** Line 8 exceeds 80 character limit by 7 characters.</s><s>** Remove line 99 [ console.log("start"); ]</s><s>** Line 100 and 103 could be re-done to document.getElementById("div") instead of having a div variable, thereby removing variable space and risk of a bug</s><s>** Extra line breaks (should be removed) on line 74,77,78</s>|-|108|file_defaultUnlock.html|diogogmt||||||||||||-|<s>103</s>|<s>file_DOMtree.html</s>|<s>diogogmt</s>||||||<s>rhung</s>||<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>||||-|112|file_limitlessScroll.html|rhung|X||||rhung: Needs to be redone to take into account where the mouse currently is rather than sending it a totally new point.|||'''FIXING'''||||-|104|file_MouseEvents.html|rhung|X||X|||northWind||'''PEER REVIEWED, SEE COMMENTS'''|||* northWind:** hangs intermittently, most likely requires focus, see [[#Waiting For Focus|here]]** 39,41: not required, handled by harness** 51: remove line, setup being called at better time @343** 60: should use === for identity as opposed to ==** 60: should add document.mozFullScreen && to condition** 61, 69: needs failure callback with is(false, ...) and SimpleTest.finish()** 68: should add && document.mozFullScreenElement === outer to condition** 68: whitespace at end of line** <s>78: looked at this briefly, are we sure that synthMs will cause the cursor to cross over the 'one' div?</s>** 172: Col 45: "the" should be "a Left"** 183-214: Why not testing for mousemove?|-|116|file_movementXY.html|diogogmt|||||| mjschranz||<b>REVIEWED, READY FOR PULL REQUEST</b>|||[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/pointerlock/file_movementXY.html file_movementXY]* mjschranz** As far as I can tell, there doesn't appear to be any styling errors. The tests run just fine and based on what I understand about it and what is listed in the comments the tests appear to function as intended.|-|<s>120</s>|<s>file_syntheticMouseEvent.html</s>|<s>diogogmt</s>||||||<s>rhung</s>|||||<s>Merged with MouseEvents test</s>|-|105|file_targetOutOfFocus.html|diogogmt|||||| mjschranz||<b>REVIEWED, SEE COMMENTS</b>|||[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/pointerlock/file_targetOutOfFocus.html file_targetOutOfFocus]* mjschranz** Line 41: the word focus is surrounded by single quotation marks, should be double ( "" ).** No other styling issues seen. Tests run and appear to be functioning as per the specs.|-|118|file_userPref.html||||X||X|||||||-|121|test_mouseLockable.html(rename to file_mozPointerLock.html)|||X|X|X|X|||||||-|122|file_nestedFullScreen.html|diogogmt||||X|| mjschranz||<b>REVIEWED, SEE COMMENTS</b>|||[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/pointerlock/file_nestedFullScreen.html file_nestedFullScreen]* mjschranz** Line 48: isLocked method call is missing opening/closing brackets. The test still passes when FullScreenHarness is run however we obviously need to fix that and ensure it's still locked as intended.** No other styling issues seen. Fix previous error and double check all tests still pass when harness is run.|-|<s>123</s>|<s>file_unlockOnUnload.html</s>|<s>northWind</s>||||X||<s>rhung</s>||<s>'''FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY'''</s>||||-|<s>120</s>|<s>file_differentDOM.html</s>|<s>diogogmt</s>||||||<s>rhung</s>||<s>'''FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY'''</s>||||-|} <!--====Test Reviews[DEPRECATED]====

|X

|X|Raymond Hung <hung.raymond@gmail.com>

|diogogmt

|diogogmt

|X

|X|Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>, Jordan Raffoul <raffoul.jordan@gmail.com>

|X

|X|Stanley Tsang <nm486@hotmail.com> Keyan Ren <rockyrky@hotmail.com>

|James Boelen <james@boelen.ca>

|diogogmt

|Hyungryul Chun (Steven) <hello.ryul@gmail.com>, Anurag Bhatnagar <bhatnagar.anurag@gmail.com>

|rhung, nm486

|Hyungryul Chun (Steven) <hello.ryul@gmail.com>, Stanley Tsang <nm486@hotmail.com>, Raymond Hung <hung.raymond@gmail.com>

|Hyungryul Chun (Steven) <hello.ryul@gmail.com>, Anurag Bhatnagar <bhatnagar.anurag@gmail.com>

|jboelen

|X

|X|Stanley Tsang <nm486@hotmail.com>, Hyungryul Chun (Steven) <hello.ryul@gmail.com>

|test_movementfile_movement.html

|rhung, nm486

|Hyungryul Chun (Steven) <hello.ryul@gmail.com>, Stanley Tsang <nm486@hotmail.com>, Raymond Hung <hung.raymond@gmail.com>

|2019

|2120

|Qian Xu <qxu26@learn.senecac.on.ca>, Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>

====Demos, Docs, Other====