Changes

�03[19:26] * Now talking in #oop-rss�03[19:26] * niven.freenode.net sets mode: +ns�03[19:28] * NULLbyte_ (~IceChat77@184.175.8.158) has joined #oop-rss�03[19:28] * robertoisaula (~robertois@CPE00222d9806d3-CM00222d9806cf.cpe.net.cable.rogers.com) has joined #oop-rss

�01[19:30] <@mdafidchao> you can just /join any channel name and if it doesn't exist it will be created

�03[19:32] * Kain-18 (~Kain-18@69-165-252-11.cable.teksavvy.com) has joined #oop-rss

[19:32] <Kain-18> �04sup sup guys

[19:33] <Kain-18> �04yeayea

�01[19:33] <@mdafidchao> he hasn't responded to my e-mail either

�01[19:34] <@mdafidchao> alright so i looked at ivan's and his edit crashes[19:34] <Kain-18> �04alrightalright

[19:34] <Kain-18> �04ivan ivan is out[19:35] <Kain-18> �04i i mean ivan's edit[19:35] <Kain-18> �04what what about michaels?�03[19:36] * NULLbyte (~IceChat77@184.175.8.158) has joined #oop-rss�01[19:36] <@mdafidchao> i tested mine as best I could, didn't see any crashes so far

[19:36] <Kain-18> �04what what bugs?

[19:37] <Kain-18> �04neither neither have i

[19:37] <Kain-18> �04okok�01[19:38] <@mdafidchao> i can't see roberto's repository

[19:39] <Kain-18> �04lollol�02[19:40] * NULLbyte_ (~IceChat77@184.175.8.158) Quit (Ping timeout: 276 seconds�seconds.)�03[19:40] * NULLbyte_ (~IceChat77@184.175.8.158) has joined #oop-rss[19:40] <Kain-18> �04michales michales edit( ) i see it the same as what the teacher gave us[19:41] <Kain-18> �04ohhh ohhh nvm�02[19:42] * NULLbyte (~IceChat77@184.175.8.158) Quit (Ping timeout: 276 seconds�seconds.)�02[19:45] * NULLbyte_ (~IceChat77@184.175.8.158) Quit (Ping timeout: 276 seconds�seconds.)�03[19:45] * NULLbyte_ (~IceChat77@184.175.8.158) has joined #oop-rss�01[19:46] <@mdafidchao> hm when I enter insert mode in sezar's edit doesn't let me add characters at the end[19:46] <NULLbyte_> yea mine is not goo[19:46] <NULLbyte_> good*[19:46] <NULLbyte_> but try the backspace�01[19:48] <@mdafidchao> it works[19:48] <Kain-18> �04lol, we get it, ur backspace works�01[19:48] <@mdafidchao> so does mine�03[19:49] * NULLbyte (~IceChat77@184.175.8.158) has joined #oop-rss[19:49] <Kain-18> �04i i tried michaels and its pretty nice, didnt find bugs, although its alot of code

�01[19:51] <@mdafidchao> branching is making a copy, our branch directories are our personal workspace stuff�01[19:51] <@mdafidchao> tagging is making an archive�02[19:51] * NULLbyte_ (~IceChat77@184.175.8.158) Quit (Ping timeout: 276 seconds�seconds.)�03[19:51] * NULLbyte_ (~IceChat77@184.175.8.158) has joined #oop-rss

�01[19:52] <@mdafidchao> so for example our first release will be 0.1, when that is sent to the trunk then we can archive (branch) that that into tags�01[19:52] <@mdafidchao> right click -> create folder

�01[19:53] <@mdafidchao> yeah

�01[19:53] <@mdafidchao> i tried salopez's code with a char string that has a NULL char in the middle of it, when i add text to the end end the chars after the null char were revealed�01[19:54] <@mdafidchao> no commit your console2.0 and a working build of 0.1 with your 2 functions�01[19:54] <@mdafidchao> like what we all have in our repositories�01[19:54] <@mdafidchao> fardad updated console.cpp so you might want to get his build first and then add your functions in�02[19:54] * NULLbyte (~IceChat77@184.175.8.158) Quit (Ping timeout: 276 seconds�seconds.)

�02[19:56] * NULLbyte_ (~IceChat77@184.175.8.158) Quit (Ping timeout: 276 seconds�seconds.)�01[19:57] <@mdafidchao> anyway, where are we so far, sezar's insert mode doesn't let me add characters at the end, salopez has a problem problem with null chars in the middle of a string (don't know if this is acutlaly an issue but I KNOW fardad used a string like this in class), ivan's crashes because he forgot to allocate +1 byte�01[19:57] <@mdafidchao> all edit btw, I'm sure everyone's display is fine[19:59] <Kain-18> �04ok ok then we can use your edit func then�01[20:00] <@mdafidchao> no one found ayhthing wrong with mine?

[20:01] <Kain-18> �04ii/ve been trying to but it seems it all works fine with your edit[20:02] <Kain-18> �04by by the way, i didnt get what was the problem with my edit.�01[20:03] <@mdafidchao> i tested your edit with a string that had a null byte in the middle of the string�01[20:03] <@mdafidchao> ex: ABCDEF\0GHIJ�01[20:03] <@mdafidchao> it displays ABCDEF fine, but when I go to add characters to the end, GHIJ gets revealed[20:03] <Kain-18> �04ohhhhhhhohhhhhhh�01[20:03] <@mdafidchao> i don't even know if that's an issue but I know that Fardad did something like this in class�03[20:04] * NULLbyte (~IceChat77@184.175.5.160) has joined #oop-rss�01[20:05] <@mdafidchao> roberto's cursor exits fieldLen when I add characters at the very end[20:05] <Kain-18> �04lollol

�01[20:06] <@mdafidchao> so far I've found at least 1 issue with everyone's edit, no one has found anything wrong with mine�01[20:06] <@mdafidchao> except that it looks like a lot of code and may be inefficient�03[20:06] * Retrieving #oop-rss modes...

[20:07] <Kain-18> �04whywhy?�01[20:07] <@mdafidchao> also I'm trying to call your edit functions with invalid values (bad offset, cursor pos, etc) and I don't think think these cases are being covered

[20:08] <Kain-18> �04i i believe all of ours

�01[20:10] <@mdafidchao> one person's code had like 4 ifs

�01[20:13] <@mdafidchao> it's inefficient i think

[20:15] <Kain-18> �04fine fine with me�01[20:15] <@mdafidchao> sure, makes things easier i guess[20:16] <Kain-18> �04alrightalright, so its michaels edit. what about display??

[20:16] <Kain-18> �04shoulndt shoulndt we look for bugs too

�01[20:17] <@mdafidchao> hm what to test for display�01[20:17] <@mdafidchao> we all tested for display to not print anything if you had it print outside the console area right

�01[20:18] <@mdafidchao> uhoh I see some hardcoded numbers[20:19] <Kain-18> �04nono!�01[20:19] <@mdafidchao> someone used 80 instead of getCols�01[20:19] <@mdafidchao> hehe

[20:20] <Kain-18> �04the the string should go to the next line if it overcomes the screen

[20:20] <Kain-18> �04lollol�01[20:21] <@mdafidchao> huh I was told to ignore wrapping[20:21] <Kain-18> �04whatwhat? the hardcoded numbers?[20:21] <Kain-18> �04reallyreally?[20:21] <Kain-18> �04i i was never told

[20:21] <Kain-18> �04nopnop[20:21] <Kain-18> �04but but ok

[20:22] <Kain-18> �04yeayea

�01[20:22] <@mdafidchao> I thought someone asked about wrapping in class and fardad said ignore it[20:23] <Kain-18> �04ohhohh, might be cause its different sections, and he didnt say anything to us

[20:23] <Kain-18> �04so so it doesnt matter

�02[20:25] * robertoisaula (~robertois@CPE00222d9806d3-CM00222d9806cf.cpe.net.cable.rogers.com) Quit (Quit: HydraIRC -> http://www.hydrairchydrairc.com <- *I* use it, so it must be good!�.)�02[20:25] * Kain-18 (~Kain-18@69-165-252-11.cable.teksavvy.com) Quit (Quit: Leaving�Leaving.)�04[20:25] <NULLbyte> yo mdafidchao can you look at the keys I added and see the problem ... me and kain-18 coudn't!!�01[20:25] <@mdafidchao> what were you trying to do�01[20:26] <@mdafidchao> CTRL + F and CTRL + U?[20:26] <NULLbyte> one key deletes everything before the curPosition (CTRLU)and one key deletes everything after the curPosition(CTRLFCTRLF)�03[20:27] * Kain-18 (~Kain-18@69-165-252-11.cable.teksavvy.com) has joined #oop-rss

�01[20:28] <@mdafidchao> hold on a sec lets figure out whos display to use

�01[20:28] <@mdafidchao> so there's 2 who used hardcoded values that are out

�01[20:28] <@mdafidchao> my edit�01[20:29] <@mdafidchao> that leaves roberto ivan and myself

�01[20:29] <@mdafidchao> yeah�03[20:29] * robertoisaula (~robertois@CPE00222d9806d3-CM00222d9806cf.cpe.net.cable.rogers.com) has joined #oop-rss

�01[20:31] <@mdafidchao> =/ don't think that's fair�01[20:31] <@mdafidchao> unless everyone agrees

�01[20:32] <@mdafidchao> after looking at all of them, i don't like robertos cause of readability + i don't think it was necessary to create vars to store getCols/getRows�01[20:32] <@mdafidchao> ivans is pretty clean from what i see

�01[20:33] <@mdafidchao> although I don't think it compiles in borland

�01[20:34] <@mdafidchao> 'cause I had to add the scope to strlen to get it to compile and I see ivan didn't do that�01[20:35] <@mdafidchao> did anyone else run into that issue when compiling in borland

�01[20:36] <@mdafidchao> oh well it's either bordland or matrix

�01[20:41] <@mdafidchao> hm ivan compiles on matrix on borland�01[20:41] <@mdafidchao> but i guess we're using mine if it looks better

�01[20:42] <@mdafidchao> cool�01[20:42] <@mdafidchao> i guess i'll branch it to trunk and tag it

�01[20:44] <@mdafidchao> gimme a sec

�01[20:49] <@mdafidchao> what am I trying to fix

�01[20:51] <@mdafidchao> ctrl f at the end of fieldlen deletes everything before the cursor, leaving only the character under the cursorcursor�01[20:51] <@mdafidchao> ctrl u just beeps�01[20:51] <@mdafidchao> when used at the end of fieldlen

�01[20:51] <@mdafidchao> so it looks like its working as intended

�01[20:52] <@mdafidchao> no idea

�01[21:00] <@mdafidchao> hm it didn't say to cover negative numbers in the thingy

�01[21:01] <@mdafidchao> not including negative numbers

�01[21:01] <@mdafidchao> numbers that go past the end of the string

�01[21:01] <@mdafidchao> as mentioned in http://zenit.senecac.on.ca/wiki/index.php/Line_Editing_Facility_-_OOP344_20113#edit.28.29_function29_function

�01[21:04] <@mdafidchao> cool

�02[21:04] * Kain-18 (~Kain-18@69-165-252-11.cable.teksavvy.com) Quit (Quit: Leaving�Leaving.)

�01[21:06] <@mdafidchao> alright

�02[21:07] * robertoisaula (~robertois@CPE00222d9806d3-CM00222d9806cf.cpe.net.cable.rogers.com) Quit (Quit: I love my HydraIRC -> httphttp://www.hydrairc.com <-�.)

�01[21:12] <@mdafidchao> tag and trunk are done