Changes

Jump to: navigation, search

JSON RPC Adapter Project

163 bytes added, 18:38, 26 November 2010
Phase 10: Apply Changes per Code Review 4 (Done)
===Phase 10: Apply Changes per Code Review 4 (Done) ===
*The <code>m_tokenValue </code> used in some of the error messages won’t always be populated. For example, in <code>parseArray()</code>, <code>m_tokenValue </code> is used, but it will only be valid if the current token is <code>TOKEN_ATOM</code>.
*The <code>boolean.invalidateToken invalidToken</code> error message can be removed and you can use just <code>err.parse.unexpectedToken </code> instead, as one doesn’t know for certain that the input is a Booldean<code>Boolean</code>. Same for <code>null.invalidateToken invalidToken</code> and <code>number.invalidToken</code>. * <code>parseObject()</code>: the <code>if (sKey == null)</code> check can never succeed, because <code>instanceof</code> should return false if its argument is <code>null</code>.
* parseObject(): the if (sKey == null) check can never succeed, because instanceof should return false if its argument is null.
===Phase 11: Code Review 11 ===
* Send code for review
1
edit

Navigation menu