1
edit
Changes
→Phase 5: Code Review 2
===Phase 5: Code Review 2 ===
* Send patch to NexJ for review
===Phase 6: Apply Changes per Code Review 2 ===
* Minor Clean Up
** Removed unnecessary files
** Ensure all files use CRLF line-endings
* Add Servlet Mapping to cert/web.xml
* GenericCharacterStreamServer
** Use <code>abstract String getType()</code> for creating error codes
** Use <code>getLogger()</code> for lazy initialization of logger
* TextServer
** Members should be protected
* JSONWriter
** Methods names should start with "write"
* JSONMarshaller
** Remove unused methods
** Remove visReferencable()</code>, do lookup in TransferObject Marshaller
* JSONUnmarshaller
** Use <code>JSONLookup</code> to find unmarshllers
** Create <code>DetachableByteArrayOutputStream</code>
** Change logic in <code>Base64Util.decode(String)</code>
** Use <code>Base64Util.decode(String)</code> to decode 64 streams
** Only TO unmarshaller should use <code>remove()</code> otherwise use <code>get()</code> on m_jsonMap
** Change instances of <code>Collection.toArray()</code> to use <code>toArray(new Object[size])</code>
===Phase 7: Code Review 3 ===
* Send patch to NexJ for review
