Changes

Jump to: navigation, search

Add an Infobar style warning for window resize/move

3,144 bytes added, 15:14, 24 September 2009
Project Details
== Description ==
Many (poorly behaved) web sites attempt to move and/or resize your browser window. It is possible to stop this behaviour (cf. dom.disable_window_move_resize) but it would be nice to have an infobar that informed the user that a web page attempted to move/resize the window, and allow it or ignore it (default). This behaviour is similar to the current Pop-up Blocker already present in Firefox. NOTE: it is not clear whether such a feature would be accepted in the tree or if this would need to be done as an extension.
== Releases ==
'''Version 1.0a''' <br />
* This patch addresses a simple issue of placing all label required "text" into the properties/dtd files.
* Addresses localization issues
* Patch can be found on bugzilla <br />
'''Version 1.0''' <br />
* This patch is mostly changes to the code to make it work in the latest firefox repository
* Changed the event number to 39. This number will need to be changed if 39 is taken later
* Changed the order of the nsClassInfo.cpp declarations (leaving mine always at the bottom)
* Fixed a number of issues where code conflicted with the newer code in the newer repository.
'''Version 0.9''' <br />
Use '''patch -p1 < InfobarFrontend0.9.txt''' for Front end code <br />
USe '''patch -p1 < InfobarBackEnd0.9.txt''' for Back end code <br />
'''Release Notes'''
* In the Options, Content Tab:
** Added a checkbox to options: Notify Move/Resize. This governs the resizeWindow.show_infobar preference
** Added Exceptions button beside it, which opens the permissions manager to add sites to the allow/block list
* This patch ties all the work together and gives the features a fully accessible interface
* Added one new test to Mochitest which tests the preference
* Fixed a bug where there were two of the same preference names in about:config (pref was added to the wrong file)
* Changed some variable naming conventions (in nsGlobalWindow.cpp is isAbsolute)
* Fixed a bug where isAbsolute is flipped when sent from nsGlobalWindow.cpp
* Added a confirmation to "Allow Once", and it shows the x and y coordinates as well as the command being blocked
** Reason being users weren't able to see what parameters were blocked.
** To allow users some freedom and knowledge about what the blocked command was before allowing it
* Fixed a bug where javascript can crash if you called "Edit options", because it was missing a try and catch block
Bug can be found in the bug info above<br />
'''Version 0.8:''' <br />
Use '''patch -1 < InfobarFrontend0.8.txt''' for Front end code <br />
== Project Details ==
'''09/04/2009''' -
* Removed "NOTE: it is not clear whether such a feature would be accepted in the tree or if this would need to be done as an extension." from project description
* Awaiting for review
'''07/04/2009''' -
* Apologies for the long break:
* Made a fix to the patch: Removed text strings and placed in a properties file.
* Update can be found on bug
'''04/25/2009''' -
* After some many many rebuilds and weird Assertion errors fixed...
* Release 1.0! Its here!! Its here!!!
'''04/24/2009''' -
* Fixed a huge array of problems migrating to the latest version of firefox
** Merged all code with kdiff3 (several conflicts)
** Event number changed from 4000 back to 39 (instead of 36)
** Reordered nsClassInfo.cpp (was throwing constructor errors at me)
** Fixed a bug where the event type was mismatching causing no actual data to be passed
'''04/23/2009''' -
* Changed Event number to 4000 (cause 36 is used in the latest version of FireFox)
* This number will be changed when this patch is official (to a more stable number)
'''04/17/2009''' -
* Video Tutorial for 0.9: http://www.youtube.com/watch?v=pOtZs4k54jg
'''04/11/2009''' -
* Not entirely related to the project, yesterday and today was spent on poster.
* Releasing 0.9 as well.
* The details can be found above.
'''04/09/2009''' -
* Added one new test to Mochitest testing resizeWindow.show_infobar
** warningLabel changed to warningLabelKey seeing how this is a key
** isByCommand changed to isAbsolute in nsGlobalWindow.cpp
** fixed a bug where moveTo and moveBy was flipped around when using allowOnce
* Deleted "showEditDialog()" from browser.js gResizedWindowObserver
* Added a confirmation dialog to "allow once", with the x and y / command type info
1
edit

Navigation menu