Open main menu

CDOT Wiki β

Changes

User:Egmetcalfe/Dead Code

1,193 bytes added, 22:58, 24 March 2010
no edit summary
Code Size: 39
 
====nsresult nsViewManager::GetViewObserver(nsIViewObserver*&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetViewObserver MXR Search]
 
Code Size: 16
====void nsView::SetPositionIgnoringChildWidgets(nscoord,nscoord)====
This is declared in the header [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.h#111 here] as taking an ncoord& parameter however it is defined [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.cpp#412 here] as taking PRInt32&. This could be problematic if [http://mxr.mozilla.org/mozilla-central/source/gfx/public/nsCoord.h#74 NS_COORD_IS_FLOAT] is defined.
 
====void nsBox::CoordNeedsRecalc(PRInt32&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=CoordNeedsRecalc MXR Search]
 
Code Size: 2
 
This is declared in the header [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.h#111 here] as taking an ncoord& parameter however it is defined [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.cpp#412 here] as taking PRInt32&. This could be problematic if [http://mxr.mozilla.org/mozilla-central/source/gfx/public/nsCoord.h#74 NS_COORD_IS_FLOAT] is defined.
 
====void nsListBoxBodyFrame::SetRowHeight(nscoord)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=SetRowHeight MXR Search]
 
Code Size: 41
 
Same situation, except SetRowHeight is declared in the [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsListBoxBodyFrame.h#112 header] as taking a PRInt32 yet the [definition http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsListBoxBodyFrame.cpp#659] lists the parameter as nscoord.
1
edit