Changes

Jump to: navigation, search

User:Egmetcalfe/Dead Code

3,081 bytes removed, 14:22, 9 April 2010
layout/xul
Code Size: 6
[http://mxr.mozilla.org/mozilla-central/search?string=SetFloatAttr MXR Search] (One use in a dead macro) *Will be used for HTML5
====nsresult nsGenericHTMLElement::GetFloatAttr(nsIAtom*,float,float*)====
[http://mxr.mozilla.org/mozilla-central/search?string=GetFloatAttr MXR Search] (One use in a dead macro) *Will be used for HTML5
Code Size: 15
====nsresult nsHTMLDNSPrefetch::PrefetchHigh(nsAString_internal&)====
[http://mxr.mozilla.org/mozilla-central/search?string=PrefetchHigh MXR Search] *- Meant as forward looking API
Code Size: 3
====nsresult nsHTMLDNSPrefetch::PrefetchHigh(Link*)====
[http://mxr.mozilla.org/mozilla-central/search?string=PrefetchHigh MXR Search] *- Meant as forward looking API
Code Size: 3
====nsresult nsHTMLDNSPrefetch::PrefetchMedium(nsAString_internal&)====
[http://mxr.mozilla.org/mozilla-central/search?string=PrefetchMedium MXR Search] *- Meant as forward looking API
Code Size: 3
====nsresult nsHTMLDNSPrefetch::PrefetchMedium(Link*)====
[http://mxr.mozilla.org/mozilla-central/search?string=PrefetchMedium MXR Search] *- Meant as forward looking API
Code Size: 3
===layout/xul===
 
====void nsBoxFrame::FireDOMEventSynch(const nsAString_internal&,nsIContent*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=FireDOMEventSynch MXR Search]
 
Code Size: 46, !
 
====void nsGridRow::MarkDirty(nsBoxLayoutState&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=MarkDirty&case=1 MXR Search]
 
Code Size: 16, !
 
====void nsBoxLayout::GetParentLayout(nsIBox*,nsIBoxLayout**)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetParentLayout MXR Search]
 
Code Size: 9, !
 
====nsGridRow* nsGrid::GetRows()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetRows(&case=on MXR Search]
 
Code Size: 3, !
 
====nsGridRow* nsGrid::GetColumns()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetColumns(&case=on MXR Search]
 
Code Size: 3, !
 
====nsresult nsMenuFrame::IsActive(PRBool&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=IsActive%5C%2528%5B%5E%2529%5D&regexp=on&case=1 MXR Search]
 
Code Size: 3, !
 
====void nsBox::AddMargin(nsSize&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=AddMargin&case=1 MXR Search]
 
Code Size: 3, !
 
===layout/base===
 
====nsIFrame* nsLayoutUtils::GetClosestCommonAncestorViaPlaceholders(nsIFrame*,nsIFrame*,nsIFrame*)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetClosestCommonAncestorViaPlaceholders MXR Search] (Calls itself)
 
Code Size: 62, !
 
====nsBidi::nsBidi(PRUint32,PRUint32)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=nsBidi(&case=1 MXR Search]
 
Code Size: 43, !
 
====nsIFrame* nsFrameManager::GetCanvasFrame()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetCanvasFrame MXR Search]
 
Code Size: 20, !
 
====nsresult nsBidiPresUtils::GetBidiEngine(nsBidi**)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=GetBidiEngine MXR Search]
 
Code Size: 8, !
 
====void nsDisplayList::DeleteBottom()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=DeleteBottom MXR Search]
 
Code Size: 7, !
 
====void nsFrameManager::ClearUndisplayedContentMap()====
 
[http://mxr.mozilla.org/mozilla-central/search?string=ClearUndisplayedContentMap MXR Search]
 
Code Size: 5, !
====gfxContext* nsContextBoxBlur::GetContext()====
6 of the functions of this class are dead but the [http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsITraceRefcnt.idl#43 idl file] lists the classes status as frozen (and deprecated).
 
== Bugs/Strangeness ==
 
===layout/xul===
 
====void nsBox::CoordNeedsRecalc(PRInt32&)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=CoordNeedsRecalc MXR Search]
 
Code Size: 2
 
This is declared in the header [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.h#111 here] as taking an ncoord& parameter however it is defined [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsBox.cpp#412 here] as taking PRInt32&. Won't compile if [http://mxr.mozilla.org/mozilla-central/source/gfx/public/nsCoord.h#74 NS_COORD_IS_FLOAT] is defined.
 
====void nsListBoxBodyFrame::SetRowHeight(nscoord)====
 
[http://mxr.mozilla.org/mozilla-central/search?string=SetRowHeight MXR Search]
 
Code Size: 41
 
Same situation, except SetRowHeight is declared in the [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsListBoxBodyFrame.h#112 header] as taking a PRInt32 yet the [http://mxr.mozilla.org/mozilla-central/source/layout/xul/base/src/nsListBoxBodyFrame.cpp#659 definition] lists the parameter as nscoord.
1
edit

Navigation menu