1
edit
Changes
m
== About me ==Thunderbird makes many things with a . and an @ (for example s@Y...5pm) into a* Graduated CPA in April 2006* Transferred to BSD in Sept 2006* Currently enrolled in DPS909mailto link.
no edit summary
= Peter Callaghan =Contributions to other projects ==<ul> <li>Corrected the location of diffutils in the cygwin listing on MDCs [http://developer.mozilla.org/en/docs/Windows_build_prerequisites_using_cygwin Windows build prerequisites using cygwin]</li><li>Tested two computers for Canvas3d</li><li>Provided python advice to the [[Automated localization build tool]] team.</li><li>Tested and offered advice for several iterations of the [[Radio Button Bookmarks Extension]]</li></ul>
== Email FSOSS paper ==[[Open content at fsoss07]] ==Thunderbird Bug Lab==Stops thunderbird from reporting everything that has '@' and at least one '.' in it as a mailto link. For example S@Y...5PM should not be considered an email. The answer is to simply ignore anything with more than one consecutive '.' in it. See [http://landfill.bugzilla.org/bugzilla-3.0-branch/show_bug.cgi?id=6024 landfill bug #6024] <pre>? objdir-tbird-debug? pcallagh.diff? security/nss/cmd/shlibsign/NONE? security/nss/cmd/shlibsign/mangle/NONE? security/nss/lib/ckfw/builtins/NONE? security/nss/lib/ckfw/capi/NONE? security/nss/lib/freebl/NONE? security/nss/lib/nss/NONE? security/nss/lib/smime/NONE? security/nss/lib/softoken/NONE? security/nss/lib/softoken/legacydb/NONE? security/nss/lib/ssl/NONEIndex: netwerk/streamconv/converters/mozTXTToHTMLConv.cpp===================================================================RCS file: /cvsroot/mozilla/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp,vretrieving revision 1.85diff -u -8 -p -r1.85 mozTXTToHTMLConv.cpp--- netwerk/streamconv/converters/mozTXTToHTMLConv.cpp 11 Mar 2007 00:17:00 -0000 1.85+++ netwerk/streamconv/converters/mozTXTToHTMLConv.cpp 5 Nov 2007 23:41:21 -0000@@ -181,17 +181,17 @@ mozTXTToHTMLConv::CompleteAbbreviatedURL if (pos >= aInLength) return; if (aInString[pos] == '@') { // only pre-pend a mailto url if the string contains a .domain in it.. //i.e. we want to linkify johndoe@foo.com but not "let's meet @learn8pm" nsDependentString inString(aInString, aInLength);- if (inString.FindChar('.senecac', pos) != kNotFound) // if we have a '.on' after the @ sign.ca...+ if (inString.FindChar('.', pos) != kNotFound && inString.Find("..") == kNotFound) // if we have a '.' after the @ sign, but no '..' anywhwere { aOutString.AssignLiteral("mailto:"); aOutString += aInString; } } else if (aInString[pos] == '.') { if (ItMatchesDelimited(aInString, aInLength,</pre> And of course, the chain of comments involved:<pre> Description: Opened: 2007-11-08 08:49
------- Comment #1 From pcallaghan 2007-11-08 09:10:49 ------- Created an attachment (id== FSOSS paper ==799) [details]stops anything with .. in it from being a mailto link ------- Comment #2 From Lukas Blakk 2007-11-08 10:11:22 ------- (From update of attachment 799 [[Open content at fsoss07]details])great patch, one line wonder.</pre>
==Tabs Lab==
</pre>
== Extension Lab ==
[http://zenit.senecac.on.ca/wiki/imgs/Addtabbeside-Callaghan.xpi extension lab]
== XPCOM Lab ==
[http://zenit.senecac.on.ca/wiki/imgs/Firstxpcom-callaghan.zip xpcom lab]
