1
edit
Changes
→Review Issues [This list consists of older issues that were resolved]
* Finish tests, updated to changes above.
* <s>Update patch to trunk</s> - humph
* <s>Figure out why DOMMouseScroll events aren't being retargeted to the locked element</s> - humph, diogogmt
* <s>Look into roc's suggestion from bug 722449 comment 8, namely, using getBoundingClientRect vs. GetPrimaryFrame()</s> - diogogmt
* <s>Maybe use nsStubMutationObserver instead of nsIMutationObserver?</s> - humph
* <s>Extensions to the Document Interface. Add pointerLockElement attribute and exitPointerLock method </s> - diogogmt
* <s>Update Element interface to have requestPointerLock </s> - diogogmt
* <s>Dispatch pointerlockchange or pointerlockerror events instead of firing a callback when pointer gets locked</s> - diogogmt
* <s>Update mochitests to use new pointerlock API</s> - diogogmt
* Add expect number of tests to mochitests
* Update patch to trunk- diogogmt ==Mochitests for new PointerLock API== To have consistency between all the tests they were updated to the following:* Through out the test flags are set to represent success or failure* runTests function will run the assertions using the flags* All assertions are located in runTests()* body onload calls start()* start() waits for focus then start running the test* If test uses fullscreen API, then runTests() and SimpleTest.finish() are called when fullscreen mode is cancelled Structure of the tests(Top-Bottom):# Test description# SpecialPowers(if nedded)# SimpleTest.waitForExplicitFinish()# var declarations# function runTests()# Some code specific to the test# pointerlockchange event listener# pointerlockerror event listener# mozfullscreenchange event listener## runTests()## SimpleTest.finish()# function start()
{| border=1 style="border: 1px solid darkgray;"
| 2
| <b>test_withoutDOM.html</b>
| diogogmt
| New
|
| Checks if element is attached to the DOM Tree before locking before locking the pointer
|-
| 2
| test_removedFromDOM.html</b>
| diogogmt
| New
| 3
| <s>file_nestedFullScreen.html</s><br /><b>test_nestedFullScreen.html</b>
| diogogmt
| YesUpated
|
| Requesting fullscreen on a child element of the element with the pointer locked should unlock the pointer
| Removed
|
| On the old spec the pointer object was attached to the navigator, so there was a possibility that an element belonging to a different DOM could request pointerlock. However, in the new API the element requests pointerlock on it self making this test redundant.
|-
| 5
| <s>file_fullscreen.html</s>
| diogogmt
| Removed
|
||Tested components of the old spec and had some redundant tests
|-
| 6
| <s>file_doubleLockCallBack.html</s><br /><b>test_doubleLock.html</b>
| diogogmt
| Renamed<br/>Updated
| 8
| <s>file_exitMouseLockOnLoseFocus.htm</s><br /><b>test_looseFocusWindow.html</b>
| diogogmt
| Renamed<br />Updated
| 11
| <s>file_movementXY.html</s><br /><b>test_movementXY.html</b>| diogogmt||Renamed<br />Updated
|
| Checks if mozMovementX and mozMovementY are present in the mouse event object. It also checks the values for mozMovementXY. They should be equal to the current screenXY minus the last screenXY
|-
| 12
| <s>file_targetOutOfFocus.html</s><br /><b>test_targetOutOfFocus</b>
| diogogmt
| Renamed<br />Updated
|
||Element doesn't need to have focus to request pointer lock
|-
|
| On the new updated spec we don't have a MozPointerLock object anymore
|-
| 15
| <s>file_cursorPosEvents.html</s><br /><b>test_suppressSomeMouseEvents</b>| diogogmt||Renamed<br />Updated
|
| Test will check to make sure that the following mouse events are no longer executed in pointer lock. - mouseover, mouseout, mouseenter, mouseleave
|-
| 17
| <s>file_defaultUnlock.html</s><br /><b>test_escapeKey</b>| diogogmt||Renamed<br />Updated
|
| Escape key should unlock the pointer
|-
| 18
| <s>file_userPref.html</s><br /><b>test_pointerLockPref.html</b>| diogogmt||Renamed<br />Updated
|
| Tests full-screen-api.pointer-lock pref
|-
| 19
| <s>file_constantXY.html</s><br /><b>test_screenClientXYConst.html</b>| diogogmt||Renamed<br />Updated
|
| Confirm that screenX/Y and clientX/Y are constants when the pointer is locked.
|-
| 20
| <s>file_pointerLockCSSDisplay.html</s><br /><b>test_cssDisplayProperty.html</b>| diogogmt||Renamed<br />Updated
|
| Pointer should not be locked to an element with css property display is set to none
|-
| 21
| <s>file_retargetMouseEvents.html</s><br /><b>test_retargetMouseEvents</b>| diogogmt||Renamed<br />Updated
|
| Retarget mouse events to the locked element
|-
|}
