Changes

Jump to: navigation, search

Real World Mozilla Incremental Build Lab

644 bytes added, 18:03, 6 October 2009
Apply a patch
[[Dive into Real World Mozilla]] > [[Dive into Real World Mozilla Day 3]] > Incremental Build Lab
== Overview ==
This lab is designed to give you first-hand experience creating and applying patches, and doing incremental builds of your source tree. The concepts introduced in this lab will help you understand how to make small changes to your tree, share those with others, or use other people's changes.
 
NOTE: portions of this lab are applicable to the tree as at the time of writing (i.e., February 27, 2007), specifically the example patches discussed below.
== Instructions ==
Because the source tree is so large, developers use patches as the basic unit of work for passing code back and forth. A patch is a text file that contains information necessary to add or remove lines from a source tree. Patches are created using the '''cvs diff''' command.
 
'''NOTE: All instructions below assume the use of an objdir. Replace all uses of ''objdir'' with your object directory path.'''
=== Making a change and doing incremental builds ===
* Make a small change to a file in your tree, for example, a .cpp file in '''mozilla/netwerk/protocol/http/src'''. Here is a possible change:
#include <stdio.h>
...
...''inside a function somewhere''...
/* DEBUG_<username> is defined at build time, and Faculty is the username in the lab */
#ifdef DEBUG_Faculty
printf("Hello World!\n");
#endif
...''inside a function somewhere''...
...
* Make sure your change compiles. You need to rebuild your tree in order to test using one of the following methods:
$ make -f client.mk build
or, to make things go faster, move to the parallel location in your ''objdir '' and run make there
$ cd mozilla/''objdir''/netwerk/protocol/http/src
$ make
=== Create a patch ===
* Now create a patch containing the changes you just made using the so called 'unified' format (-u), with 8 lines of context. By default the diff is printed to stdout, so you should redirect it to a file. Typically patches are created from the '''mozilla/''' root directory, so that they can be easily applied later on (i.e., people don't have to figure out where to apply the patch, and can just use their tree's root directory):
$ cd mozilla/netwerk/protocol/http
$ cvs diff -u8p . > patch.txt
* Trade patches with someone else in the class (use http://pastebin.mozilla.org and IRC), and take turns trying to apply their patch to your tree:
$ cd mozilla/netwerk/protocol/http
$ patch -p0 < patch.txt
* Here -p0 means strip 0 leading directories from each filename in the patch. We do this because we (unless you are in the same location (iusing hg checkout/patches then you want to look here [https://developer.emozilla., org/en/Mercurial_FAQ#How_can_I_diff_and_patch_files./3f for updated instructions]) as the person who created the patch. If the directories were mis-aligned, we would have to strip leading directories using -p1, -p2, etc.
* Here '''-p0''' means strip 0 leading directories from each filename in the patch. We do this because we are in the same location (i.e., ./) as the person who created the patch. If the directories were mis-aligned, we would have to strip leading directories using -p1, -p2, etc. * You can use the '''--dry-run ''' option to test and see what would happen if you did apply the patch. Some people like to call patch with the -s or --silent or --quiet option (all do the same thing). This will suppress all output except error messages, and can make it easier to see which parts don't work.
=== Backing-out a patch ===
* Now try backing-out this same patch. To do this you can call patch with the -R or --reverse option to tell it to swap the old and new files, basically reversing the patch.
$ cd mozilla/netwerk/protocol/http
$ patch -R -p0 < patch.txt
=== Applying a real patch ===
* One of the projects a Seneca student (Andrew Smith) has been working on is support for animated PNGs (Mozilla's [[APNG]http://shaver.off.net/diary/2007/08/25/tbeachball/ Mike Shaver wrote]]). The work about an idea to add instrumentation to Firefox in order to determine how much time is nearing completion and being reviewedspent away from the main event loop. Start by reading His blog post included prototype code in the bug: httpsform of a [http://bugzillashaver.mozillaoff.orgnet/show_bugmisc/latency-tracing-patch.cgi?id=257197txt patch].
* Download AndrewMike's latest patch ([httpshttp://bugzillashaver.mozillaoff.orgnet/misc/attachmentlatency-tracing-patch.cgi?id=254449 attachment 254449txt patch] at the time of writing). '''Save the file ''' (do not copy-paste it) to your '''mozilla /''' directory.
* Apply the patch: , using what you learned above. $ cd mozilla $ patch Remember the '''--dry-p1 < [run''patch_filename'']option and to examine the paths of files in the patch.
* Rebuild the necessary parts of your tree:
$ cd mozilla/''objdir'' $ cd modules/libimg $ make $ cd ../libpr0n $ make $ cd ../../browser/app $ make cleanxpcom
$ make
or, if you prefer one long command:  cd mozilla/objdir/modules/libimg && make && cd ../libpr0n && make && cd ../../browser/app && make clean && make * Run your browser and load the APNG images at: http://littlesvr.ca/apng/watch for messages in stderr
=== Life-cycle of a patch in review ===
== Resources ==
* [http://developer.mozilla.org/en/docs/Creating_a_patchCreating a patch for Mozilla]* [http://developer.mozilla.org/devnews/index.php/2007/07/10/getting-a-patch-checked-in/ Instructions for getting a patch checked into the tree]* There are many tutorials on using diff/patch, for example [http://tools.devchannel.org/devtoolschannel/04/06/02/1521207.shtml?tid=46 this one].

Navigation menu