Changes

Jump to: navigation, search

PostgreSQL Adapter Project - Code Review 4 Changes

198 bytes added, 16:54, 15 September 2011
PostgreSQLPreparedStatementProxy
! Status
|-
|*Provide a class comment||-|*Prepend a comment "// inner classes"||-|*Use visibility declarators on members ("protected")||-|*Fold lines after about 110 chars|'''DONE'''
|-
|requestSavepoint
*The statement cleanup should be fixed. Right now it will not close the statement if an error occurs.
|
* I think not, since the savepoints are only created inside a transaction block
* No, the driver does not allow setSavePoint on XA transaction (org.postgresql.xa.PGXAConnection)
*'''DONE'''
*'''DONE'''
|}
1
edit

Navigation menu