Difference between revisions of "PostgreSQL Adapter Project - Code Review 4 Changes"
(→PostgreSQLSchemaManager) |
|||
Line 1: | Line 1: | ||
[[category: NexJ Express PostgreSQL]] | [[category: NexJ Express PostgreSQL]] | ||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
− | |||
==Classes== | ==Classes== | ||
===Table=== | ===Table=== | ||
Line 227: | Line 215: | ||
*This might be worth refactoring further by adding a template method in order to avoid code duplication with the base class. | *This might be worth refactoring further by adding a template method in order to avoid code duplication with the base class. | ||
| | | | ||
+ | |- | ||
+ | |{ | ||
+ | ; | ||
+ | } undo the change to ; | ||
+ | |'''DONE''' | ||
|} | |} |
Revision as of 13:07, 20 September 2011
Contents
Classes
Table
Task | Status |
---|---|
getQuotedName
|
DONE |
SQLAdapter
Task | Status |
---|---|
setQueryTimeout()
|
DONE |
CancelTask -> StatementCancelationTask;
|
DONE |
SQLSchemaManager
Task | Status |
---|---|
addColumn
|
DONE |
I think the portable flag should not take into account columns that are not added to the table (return null in this case)? | DONE |
The message about ignoring an index has changed
|
Diff is malfunctioning |
There are extensive changes to readSchema?
|
Diff is malfunctioning |
getAlterColumnToken
|
DONE |
isPortable()
This hampers method reusability.). |
DONE |
isWindowsCompatiable -> isWindowsCompatible | DONE |
StatementProxy/PreparedStatementProxy
Task | Status |
---|---|
*Proxy.java -> *Wrapper.java
|
DONE |
PostgreSQLAdapter
Task | Status |
---|---|
MAX_FIELD_PRECISION - is this from the PostgreSQL documentation?
|
DONE |
BIND_BLOB
You already have this value, no need to get it again later on. Use Primitive.createLong() to create the long value.
|
DONE'
|
BIND_STRING, BIND_BINARY
|
|
RequestTimeout should take into account non-positive timeouts. | values <=0 do not get to requestTimeout |
The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel)
|
DONE |
unwrap
|
- PGXADataSource is the one that gives pooled connections |
s_PGXAConnection, s_getQueryExecutor
|
-s_PGXAConnection used to ensure that reflected methods and properties loaded successfully |
appendIdentitySuffix
|
DONE |
appendLiteral
|
DONE
|
appendTypeConversion
|
DONE
|
indexNameMatches
|
DONE |
isUnicode
|
DONE |
PostgreSQLPreparedStatementProxy
Task | Status |
---|---|
*Provide a class comment
|
DONE |
requestSavepoint
|
|
PostgreSQLSchemaManager
Task | Status |
---|---|
appendColumnAlteration
|
DONE
|
appendLOManagerTrigger
|
DONE |
appendTSIncrement
|
DONE |
getGUIDExpr
|
DONE |
isImplicitConversion
|
DONE |
isValidColumnName
|
DONE |
addColumn
|
|
{
} undo the change to ; |
DONE |