Open main menu

CDOT Wiki β

Changes

PostgreSQL Adapter Project - Code Review 4 Changes

186 bytes added, 14:56, 19 September 2011
PostgreSQLSchemaManager
*Use getColumnAlterationToken
*Are booleans indexable in Postgres? If not, we should use integers instead.
|'''DONE'''*Yes, it supports indexing booleans. Suggested use is with partial indexes on the condition that queries will use most often.
|-
|appendLOManagerTrigger
*Method JavaDoc comments are required.
*What does this do?
|'''DONE'''
|-
|appendTSIncrement
*interval' – perhaps a space before "'" for readability?
|'''DONE'''
|-
|getGUIDExpr
*Remove "XXX: from the comment
*Move the comment to the class header comment
|'''DONE'''
|-
|isImplicitConversion
*srcType == Primitive.BOOLEAN ) - remove space before )
|'''DONE'''
|-
|isValidColumnName
*Spaces around "-"
|'''DONE'''
|-
|addColumn
1
edit