Changes

Jump to: navigation, search

PostgreSQL Adapter Project - Code Review 1 Changes

494 bytes added, 08:57, 7 July 2011
no edit summary
[[category: NexJ Express PostgreSQL]][[category: NexJ Express Development]] [[category: NexJ Express]]
 
=General Research=
http://www.postgresql.org/docs/8.3/static/lo.html#AEN104018
|}
 
=Classes=
 
 
==PostgreSQLAdapter==
{| border="1" cellpadding="4" cellspacing="2" style="border: 1px solid black;border-collapse:collapse;"
! Status
! UnitTest
|-
|* Extending CaseInsensitiveSQLAdapter
|'''DONE'''
|'''DONE'''
|-
|Implement setQueryTime with Timer object
* if code variation is limited, extract to SQLAdapter
|'''DONE'''
|'''DONE'''
|-
| Refactor escaping literals
* May be make use isLiteral
|'''DONE'''
|'''DONE'''
|-
|appendMatchExpression
* Remove implementation of MatchNode.WEIGHT.SYMBOL
|'''DONE'''
|'''DONE'''
|-
|indexNameMatches
* Use toMetadataCase and toDatabaseCase instead of toLowerCase/toUpperCase
|'''DONE'''
|'''DONE'''
|-
|appendSuffixHint
* Implement query locking for OUTER JOIN queries (i.e. repeatable read + exclusive lock)
|'''DONE'''
|'''DONE'''
|-
| appendLiteral
* If boolean constants are supported, use those instead of string 't'/'f'
|'''DONE'''
|'''DONE'''
|-
| getBind
* Check if override is necessary
|'''DONE'''|'''DONE'''
|-
| isLiteral
* Use string.length and binary.getSize to ensure less than 1GB
|'''DONE'''
|'''DONE'''
|-
| appendTypeConversion
* Ensure case Primitive.TIMESTAMP_ORDINAL: returns milliseconds (extract(epoch from
|'''DONE'''
|'''DONE'''
|-
| isUnicode
* TRUE == is a unicode column FALSE == is not a unicode column null == unknown (e.g. number column or column not present)
|'''DONE'''
|'''DONE'''
|-
| s_bindFactoryArray[Primitive.BINARY_ORDINAL]
* Modify pattern to remove dependency on english words
|'''DONE'''
|'''DONE'''
|-
|s_bindFactoryArray
* Use parent BINDS for unchanged binds
|'''DONE'''
|'''DONE'''
|}
 
==PostgreSQLSchemaManager==
! Status
! UnitTest
|-
|* Extending CaseInsensitiveSQLSchemaManager
|'''DONE'''
|'''DONE'''
|-
|Override setCustomDatabaseProperties
*Add template fields for postgreSQL scripts
|'''DONE'''|'''DONE'''
|-
|dropTable
* Remove <code>if exists</code>
|'''DONE'''
|'''DONE'''
|-
|getGUIDExpr
|remove trigger and procedure suffix $uid
|'''DONE'''
|'''DONE'''
|-
|getDefaultLongspace, getDefaultTablespace, getDefaultIndexspace
* check if override is needed
|'''DONE'''
|'''DONE'''
|-
|generateIndexName
* Check if toLowerCase is needed
|'''DONE''''
|'''DONE'''
|-
|appendColumnType
* check if serial and bigserial have limits when compared to using sequences
|'''DONE'''
|'''DONE'''
|-
|Refactor creating and deleting full-text search indexes
** dropFullTextSearchTrigger
|'''DONE'''
|'''DONE'''
|-
|Refactor checking for BLOB column to isBLOB
|'''DONE'''
|'''DONE'''
|-
|Refactor checking for full-text search index on a column to getFullTextIndex
|'''DONE'''
|'''DONE'''
|-
|alterColumn - use this logic
* create the deleted view/s
|'''DONE'''
|'''DONE'''
|-
|renameColumn - use this logic for
* create full-text search trigger
|'''DONE'''
|'''DONE'''
|-
|dropIndex
** drop full-text search trigger
|'''DONE'''
|'''DONE'''
|-
|appendColumnAlternation
* fix full-text search trigger maintainence
|'''DONE'''
|'''DONE'''
|-
|deleteLargeObjects
* change to use for loop instead of iterator
|'''DONE'''
|'''DONE'''
|-
|getIndexInfo
*check if override is needed for
|'''DONE'''|'''DONE'''
|-
| Use toMetadataCase and toDatabaseCase instead of toLowerCase/toUpperCase
|'''DONE'''
|'''DONE'''
|}
|-
|Add comment to enable PREPARE TRANSACTION
|'''DONE'''|'''DONE'''
|-
|Use template field to set location of contrib folder
*make use of ${path}
|'''DONE'''
|'''DONE'''
|-
|Add template field to set location for tablespace, indexspace and longspace
|'''DONE'''
|'''DONE'''
|-
|Add SQL to create tablespace, indexspace and longspace
|'''DONE'''
|'''DONE'''
|-
|Move function creation to postgresql_create.sql
|'''DONE'''
|
|-
|}
 
==postgresql_drop.sql==
1
edit

Navigation menu