Open main menu

CDOT Wiki β

Changes

JSON Integration Adapter Code Review 1 Changes

229 bytes added, 20:52, 26 January 2014
no edit summary
{{Admon/obsolete}}
 
[[category: NexJ Express JSON Message Adapter]]
* Create localization strings in en.strings
* Use message part as argument to exceptions and not the whole message
| In ProgressComplete for formatter, may be revisited for parser
|-
| Documentation
* Lines that create new Objects should be between newlines
* Add newline before break
| Complete for now (revisit later)
|}
* Replace screenshots of Messages with valid messages (some values where missing type)
* Make note of any normally standard features which are not implemented by the JSON parser/formatter
* Add section about required parts and null values* Add section about channels with multiple messages| In ProgressComplete
|}
| InvocationContextAware
* Do not implement the invocation context aware interface if not used by the class
| Complete
|-
| Rename methods XXXNode to XXXPart
| Complete
|-
| fail
1. Wrap fail so that is throws expection right away<br>
2. Move fail statements from bottom to top, remove else clauses
| 1. Complete <br>2. Incomplete
|-
| parse()
| parsing primitive values
* Use primitive formatter on values that are parsed before storing them
| Complete
|}