Changes

Jump to: navigation, search

Cue Times

5,166 bytes added, 23:40, 30 September 2012
Dale: renamed files
== Tests ==
=== TC3000 - TC3099: Dale ===URL to git repo with tests: https://github.com/daliuss/webvtt/tree/cueTimeTests/test/spec
<table border='1'>  <tr>  <th>Filename</th>  <th>Description</th>  <th>Should Pass / Fail?</th>  <th>Reasoning</th>  <th>Creation Note</th>  <th>Comments</th>  </tr>   <tr>  <td>cuetime_bareminimum.vtt</td>  <td>Bare minimum file that passes (no cue content)</td>  <td>Pass</td>  <td>Conforms to spec</td>  <td>ST2</td>  <td></td>  </tr>  <tr>  <td>cuetime_bareminimum_content.vtt</td>  <td>Bare minimum file that passes (cue content)</td>  <td>Pass</td>  <td>Conforms to spec</td>  <td>ST2</td>  <td></td>  </tr>  <tr>  <td></td>  <td></td>  <td></td>  <td></td>  <td></td>  <td></td>  </tr>TC3100 - TC3199: Deva
TC3200 - TC3299: Vince
=== Dale ===
URL to git repo with tests: https://github.com/daliuss/webvtt/tree/master/test/spec
{| border="1"
|-
|class="header"|'''Filename'''
|class="header"|'''Description'''
|class="header"|'''Should Pass / Fail?'''
|class="header"|'''Reasoning'''
|class="header"|'''Creation Note'''
|class="header"|'''Comments'''
|class="header"|'''Peer Review'''
|-
|tc3200-bare_minimum.test
|Bare minimum file that passes (no cue content)
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|
|09/27 by Vince
|-
|tc3201-bare_minimum_content.test
|Bare minimum file that passes (cue content)
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|Should the content be there or is someone else testing this?
|09/27 by Vince
|-
|tc3202-highest_values.test
|Highest legal values allowed in time stamps
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|Can hours go to 3 digits? I think it can.
|09/27 by Vince
|-
|tc3203-space_tabs.test
|Lots of tab/space chars between timestamps and "-->"
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|
|09/27 by Vince
|-
|tc3204-tabs.test
|Using tab characters instead of space characters
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|Should the comment be there?
|09/27 by Vince
|-
|tc3205-hours.test
|Includes optional hours characters in timestamps
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|
|09/27 by Vince
|-
|tc3206-multicues.test
|The second cue's start time and the first cue's end time are the same
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|
|09/27 by Vince
|-
|tc3207-nestedcues.test
|Some cue times are nested within another cue
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|Thank you for testing this! I'll make a broken one later.
|09/27 by Vince
|-
|tc3208-overlappingcues.test
|There is overlap time between the two cues
|Pass
|Conforms to spec (section 3.1 in W3C draft)
|ST2
|
|09/27 by Vince
|-
|}
</table>
=== Vince ===
I'm gonna remake the table using markdown. Hitting <td></td> is tedious
|class="header"|'''Peer Review'''
|-
|bad01tc3201.vtttest
|'''00:00.000 --> 00:00.000'''
|Fail
|
|
 |Dale, Sept 26 2012
|-
|bad02tc3202.vtttest
|00:00.'''001''' --> 00:00.000
|Fail
|
|
 |Dale, Sept 26 2012
|-
|bad03tc3203.vtttest
|00:00.000 00:00.001
|Fail
|
|Took out the -->
 |Dale, Sept 26 2012
|-
|bad04tc3204.vtttest
|00:00.'''0000''' --> 00:00.001
|Fail
|
|
 |Dale, Sept 26 2012
|-
|bad05tc3205.vtttest
|00:'''000'''.000 --> 00:00.001
|Fail
|
|
|Dale, Sept 26 2012
|-
|tc3206.test
|'''000''':00.000 --> 00:00.001
|Fail
|Minutes should be 2 digits
|
|
|Dale, Sept 26 2012
|-
|tc3207.test
|'''00:'''0:00:00.000 --> '''00:'''0:00:00.001
|Fail
|No support for days
|
|Not that hours can go for a VERY long time, I tried up to 2 billion
|
|-
|tc3208.test
|:00:00.000 --> 00:00.001
|Fail
|Time stamp must start with a number
|
|Could do a lot of test cases for this using every symbol/alphabet
|
|-
|tc3209.test
|00:01.000 --> 00:01.001 <br /><br /> 00:00.000 --> 00:00.001
|Fail
|Second time stamp must be greater or in-between the first one (nested)
|
|'''Look up nested cues'''
|
|-
|}
'''TODO:''' Break hour, see if days work, create multiple cue times that don't make sense (first cue at 2 minutes, second at 1 minute)
=== Deva ===
Writing some test cases that not covered by Dale or Vince
{| border="1"
|-
|class="header"|'''Filename'''
|class="header"|'''Description'''
|class="header"|'''Should Pass / Fail?'''
|class="header"|'''Reasoning'''
|class="header"|'''Creation Note'''
|class="header"|'''Comments'''
|class="header"|'''Peer Review'''
|-
|[https://github.com/gobihun/webvtt/blob/master/test/spec/bad/TC3100_cuetime_minute_BAD.test TC3100_cuetime_minute_BAD.test]
|Minute should have only two characters in the range U+0030 to U+0039.
|Fail
|W3C WebVTT Standard - Explained in 3.1 Syntax
|
|
|
|-
|bad06[https://github.com/gobihun/webvtt/blob/master/test/spec/bad/TC3101_cuetime_second_BAD.test TC3101_cuetime_socond_BAD.vtttest]|'''000''':00.000 --> 00:00Second should have only two characters in the range U+0030 to U+0039.001
|Fail
|Minutes should be 2 digitsW3C WebVTT Standard - Explained in 3.1 Syntax|
|
|
|-
|[https://github.com/gobihun/webvtt/blob/master/test/spec/bad/TC3100_cuetime_spacetab_BAD.test TC3102_cuetime_spacetab_BAD.test]
|Between timestamp and '-->' should have one or more white space/s.
|Fail
|W3C WebVTT Standard - Explained in 3.1 Syntax
|
|
|
|-
 |[https://github.com/gobihun/webvtt/blob/master/test/spec/bad/TC3100_cuetime_starttime_BAD.test TC3103_cuetime_starttime_BAD.test]|Start time must be greater than last cue start time.|Fail|W3C WebVTT Standard - Explained in 3.1 Syntax||||- |} == Summary == === Cue Timestamp - Minimum Requirement ===* Starting "WEBVTT" title* Two or more WEBVTT line breakers* Cue start time* One or more U+0020 SPACE characters or U+0009 TABULATION characters* The string "-->" (U+002D HYPHEN-MINUS, U+002D HYPHEN-MINUS, U+003E GREATER-THAN SIGN).* One or more U+0020 SPACE characters or U+0009 TABULATION characters* Cue end time<pre>WEBVTT 00:00.000 --> 05:00.000</pre>  === Cue Timestamp Rules ===1. Should start with any characters in the range of U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9) 2. Can not have any characters other than * U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9).* one U+002E FULL STOP character (.).* one U+003A COLON character (:) only if the hour is zero and not included, if not, two U+003A COLON character (:).3. Optionally (required if hour is non-zero) include * Hour - one or more characters in the range U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9)4. Should include * Minute - 2 characters in the range of U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9). Range 00 to 59.* Second - 2 characters in the range of U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9). Range 00 to 59.* Millisecond - 3 characters in the range of U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9). Range 000 to 999.5. U+003A COLON character (:) should be used to separate* Hours and Minute* Minute and second6. U+002E FULL STOP character (.) should be used between second and millisecond  '''Timestamp format without hour'''TODO<pre>MM:SS.sss</pre> ''' Break Timestamp format with hour, see if days work, create multiple '''<pre>HH:MM:SS.sss</pre> : HH - Hour (1 or more characters): MM - Minute (2 character): SS - Second (2 character): sss - Millisecond (3 character) === Cue Start Timestamp Rule ===* The cue start timestamp must be greater or equal to last cue times that don't make sense start time (first Applicable only if there are any previous cue at 2 minutes, second at 1 minutetime stamps available=== Cue End Timestamp Rule ===* The cue end timestamp must be greater than start time
1
edit

Navigation menu