Open main menu

CDOT Wiki β

Changes

Implementing the Mouse Lock API in Firefox

9 bytes added, 00:46, 20 December 2011
Review Issues
* <s>Space, bracing, tabs, etc style nits</s> humph
* <s>clientX, clientY, screenX, screenY values should follow spec as per [https://bugzilla.mozilla.org/show_bug.cgi?id=633602#c55 scheib's comment]</s> diogogmt
* Confirm |aEvent->lastRefPoint = nsIntPoint(bounds.width/2, bounds.height/2);| that / 2 is rightdiogogmt
* "nsCOMPtr<nsIContent> mMouseLockedElement; - Shouldn't this be a static member variable? Or how does the patch handle cases when the document which has iframe and mouse moves over those iframes." Probably wants a test for this case, too.
* "nsDOMMouseLockable::ShouldLock...QI to nsINode and check IsInDoc()" diogogmt
1
edit