1
edit
Changes
no edit summary
** Change instances of <code>Collection.toArray()</code> to use <code>toArray(new Object[size])</code>
===Phase 7: Code Review 3 (Done) ===
* Send patch to NexJ for review
===Phase 8: Apply Changes per Code Review 3 (Done)=== ===Phase 9: Code Review 4(Done) ===* Send patch to NexJ for review===Phase 10: Apply Changes per Code Review 4(Done)===
*JSONWriter.java:
**Can a StringBuilder be used instead of a StringBuffer? Maybe the same change can be done in TextMarshaller as well? The member field can still be called m_buffer. Using StringBuilder instead of StringBuffer avoids the synchronization overhead.
**please remove the parts of tests that are duplicated. For example, in testServerObjects() you test the serialization of a Symbol called “sym”, a PrivilegeSet of “480000”, and a PCodeFunction with code 0, 1, 2. But these have already been tested by the “testSerializeRequestCheckJSON” which uses the m_request object initialized by the superclass.
**Use Primitive.createInteger, Primitive.createLong, etc. instead of new Integer(…), new Long(…), etc. where possible.
===Phase 911: Code Review 4 5(Done) ===
* Send patch to NexJ for review
===Phase 1012: Apply Changes per Code Review 4 5 (Done) ===
*The m_tokenValue used in some of the error messages won’t always be populated. For example, in parseArray(), m_tokenValue is used, but it will only be valid if the current token is TOKEN_ATOM.