Open main menu

CDOT Wiki β

Changes

DPS909 & OSD600 Winter 2017

1,094 bytes added, 13:03, 6 March 2017
no edit summary
==Week 8==
 
* Code Review
** A change to the project is done by a contributor '''and''' a reviewer (and maybe more than one of each).
** No one is on their own doing work. No one is solely to blame for what happens next, good or bad.
** Automated vs. Manual code review
*** Linters (eslint, standard, csslint, etc)
*** Travis CI
** Code review as scaling factor: enabling contributions
** Code review has nothing to do with how good you are at programming, isn't a value statement about you.
 
* Questions
** Do you need review on a one line change? A one word change? Why?
** What are the types of changes/results that you need to review? What is the process like?
** How does code review differ from pair programming, or working directly with a partner in the class/office?
 
* GitHub Code Reviews
** [https://help.github.com/articles/requesting-a-pull-request-review/ Asking for a review on a PR]
** [https://help.github.com/articles/about-pull-request-reviews/ PR Reviews]
 
* Let's do some reviews
** https://github.com/mozilla/thimble.mozilla.org/pulls
** https://github.com/mozilla/brackets/pulls
* [[DPS909 & OSD600 Winter 2017 Release 0.2 | 0.2 Release (Due Tues Mar 7)]]