1
edit
Changes
comments
I just completed the lab succesfully.
The steps seem pretty clear to me. Here's some issues I found though:
Before instructing the student to start firefox with
"../../dist/bin/firefox.exe -p minefield --no-remote"
I would remind the user to do this line though
"export XPCOM_DEBUG_BREAK=warn"
At the "Success, and some bugs" section, I found the deleting tabs had been broken. I know this is fixed later by fixing the issue with position but it might be nice to state it is the result of that bug.
Everything else seems fine.
The steps seem pretty clear to me. Here's some issues I found though:
Before instructing the student to start firefox with
"../../dist/bin/firefox.exe -p minefield --no-remote"
I would remind the user to do this line though
"export XPCOM_DEBUG_BREAK=warn"
At the "Success, and some bugs" section, I found the deleting tabs had been broken. I know this is fixed later by fixing the issue with position but it might be nice to state it is the result of that bug.
Everything else seems fine.