667
edits
Changes
→High-Level Mouse Lock Implementation Tasks
This list is incomplete, and needs more detail added as the following bits are completed.
====Implementation====
# <s>No mouse cursor is displayed when the mouse is locked</s> - rhung
# <strike>When mouse lock is enabled clientX, clientY, screenX, and screenY must hold constant values as if the mouse did not move at all once mouse lock was entered.</strike> humph
# <s>Freeze mouse pointer in centre of window when mouse lock is enabled (e.g., moving the mouse causes an event, but forces the mouse to go back to the original position).</s> - JSilver999
# "Once mouse lock is acquired, stop mouse events from being fired to other elements that are not locked (e.g., only fire to locked element)."
# "The Mouse Lock API must exit the mouse lock state if the user agent, window, or tab loses focus"
# "When unlocked, the system cursor can exit and re-enter the user agent window. If it does so and the user agent was not the target of operating system mouse move events then the most recent mouse position will be unknown to the user agent and movementX/Y can not be computed and must be set to zero"
# "User agents may prompt for confirmation before locking, this preference may be saved as a content setting" How to deal with this? What UI do we use? See also, "Repeated escapes of mouse lock can signal user agent to not re-lock the mouse without more specific user intent gesture, e.g. similar to how Chrome suppresses repeated alert() calls"
# User agents may prompt for confirmation before locking, this preference may be saved as a content setting (Mentioned in class by humphd, setting would be in about:config ) mjschranz
# <strike>Figure out [[Mac Crash with Jesse's SynthesizeMouseMove change]]</strike> humph
# Trying to lock a locked element should fire the success callback
# Before locking the mouse check if the element is a DOM element and if it is in the DOM Tree
# Save the screenX and screenY position before locking the mouse
# Restructure Lock method to do most of its operations in a separate thread.
====Tests====
The central repo with all the tests are located [https://github.com/rhung/mozilla-central/tree/mouselock-tests here]. For more information on how to make mochitests and how to send the pull request to the appropriate person, check out the [http://zenit.senecac.on.ca/wiki/index.php/Mochitest_FAQ Mochitest FAQ] List tests we need below:
# "there is no limit to how far movement can go...not limited by screen boundaries" -- mouse lock should mean infinite movement in the X and Y axes...There will be no limit to movementX/Y values if the mouse is continuously moved in a single direction" - '''hchun'''
# "The concept of the mouse cursor will have been removed, and it will not move off the window or be clamped by a screen edge" - '''hchun'''
# "no mouse cursor is displayed" -- mouse cursor should be hidden while locked - '''dvillase'''
# navigator.pointer (readonly) is a MouseLockable - <strong>abhatnagar</strong>
# MouseLockable has lock(), unlock(), islocked() - <strong>abhatnagar</strong>
# islocked() returns true if mouse is locked, false if not locked - <strong>JSilver999</strong>
# lock(target) expects a DOM element, and takes two optional callbacks: successcallback, failurecallback. - <strong>JSilver999</strong>
# lock() should return immediately and call callbacks when lock succeeds or fails - <strong>JSilver999</strong>
# "Mouse lock must succeed only if the window is in focus" - '''johnno'''
# "Mouse lock must succeed only if...the user-agent is the active application of the operating system" - '''johnno'''
# "The target of lock need not be in focus" - '''johnno'''
# "Mouse lock must succeed only if the target is in the DOM tree" - '''Anachid'''
# "If the target is removed from the DOM tree after mouse lock is entered then mouse lock will be lost." - '''Anachid'''
# "If the mouse is already locked to the same element, a repeated call to lock will succeed and the successCallback called" - '''jboelen'''
# "If another element is locked [and lock() is called] a user agent must transfer the mouse lock to the new target and call the mouselocklost callback for the previous target" - '''jboelen'''
# "The Mouse Lock API must provide a default system action to unlock the mouse" namely ESC. - '''CloudScorpian'''
# "Once in the locked state the user agent must fire all relevant user generated MouseEvent events (for example: mousemove, mousedown, mouseup, click, wheel)[DOM-LEVEL-3-CORE] to the target of mouse lock, and not fire mouse events to other elements" - '''rhung'''
# "Events that require the concept of a mouse cursor must not be dispatched (for example: mouseover, mouseout)" - '''rhung'''
# "Movement and button presses of the mouse must not cause the window to lose focus" - '''asahota'''
# "Synthetic mouse events created by application script act the same regardless of lock state" - '''Tentacle'''
# "The unlock method cancels the mouse lock state" - '''abhatnagar'''
# "[Upon unlock() t]he system mouse cursor must be displayed again and positioned at the same location that it was when mouse lock was entered (the same location that is reported in screenX/Y when the mouse is locked)" - '''dvillase'''
# "When mouse lock is lost or disabled for any reason user agents must fire an event named mouselocklost with its bubble attribute set to true to the mouse lock target element" - '''stsang'''
# MouseEvent must contain (readonly) movementX and movementY - '''KeyR'''
# "The members movementX and movementY must provide the change in position of the mouse, as if the values of screenX/Y were stored between two subsequent mousemove events eNow and ePrevious and the difference taken movementX = eNow.screenX-ePrevious.screenX" - '''KeyR'''
# "movementX/Y must be valid regardless of mouse lock state" - '''KeyR'''
# "When unlocked, the system cursor can exit and re-enter the user agent window. If it does so and the user agent was not the target of operating system mouse move events then the most recent mouse position will be unknown to the user agent and movementX/Y can not be computed and must be set to zero" - '''moussa1'''
# "When mouse lock is enabled clientX, clientY, screenX, and screenY must hold constant values as if the mouse did not move at all once mouse lock was entered" - '''jbraffoul'''
# "The Mouse Lock API must exit the mouse lock state if the user agent, window, or tab loses focus" - '''drigato'''
# Test to make sure that mouse lock only occurs when an element is in full screen mode (not F11 or done via the menus). This includes:
## Switching focus to another window - '''jsiu3'''
# Tests for mouselocklost event - '''Roman'''
====Demos, Docs, Other====
# Proper IDL documentation for navigator.pointer (see example in https://mxr.mozilla.org/mozilla-central/source/dom/interfaces/html/nsIDOMHTMLElement.idl#103), MouseLockable and its methods, MouseLockLost event, etc.
# Write a JavaScript library to somehow combine element.mozRequestFullScreen() and navigator.pointer.lock(). It would be good to hide the complexities of doing fullscreen then locking in a single API call. - nm486
# Mouse lock specification fix requests
# Convert Rescue Fox to use Mouse Lock, see https://github.com/mozilla/rescuefox
# <strike>Convert http://cjcliffe.github.com/CubicVR.js/cubicvr/samples/fps_demo/level1.html to use Mouse Lock</strike> - JSilver999
# Create a tutorial on how to use Mouse Lock, with code examples
# Add demo pages to [http://humphd.github.com/mozilla-central/mouselock/index.html gh-pages branch]
# Review https://developer.mozilla.org/en/API/Mouse_Lock_API for correctness with spec + our implementation