Open main menu

CDOT Wiki β

Changes

PostgreSQL Adapter Project - Code Review 4 Changes

185 bytes added, 10:48, 14 September 2011
no edit summary
|-
|RequestTimeout should take into account non-positive timeouts.
|values <=0 do not get to requestTimeout
|-
| The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel)
*should be moved to the cancelation task, as static methods.
*The timer singleton instance (lazy initialized) should be there as well.
|'''DONE'''
|-
|unwrap<br/>
*why is a pooled connection ever used there?
*When could an exception occur?
*Are we using the correct data source class?
|
- PGXADataSource uses pooled connections<br/>
- When using data load/schema tool<br/>
- Yes, PGXADataSource is the correct data source class
|-
|s_PGXAConnection, s_getQueryExecutor
1
edit