Open main menu

CDOT Wiki β

Changes

JSON Integration Adapter Code Review 1 Changes

260 bytes removed, 14:46, 10 August 2011
JSONMessageParser
{| border="1" cellpadding="4" cellspacing="2" style="border: 1px solid black;border-collapse:collapse;"
|-
! Issue! DescriptionTask
! Status
|-
| Remove/Use InvocationContextAware| * Do not implement the invocation context aware interface if not used by the class. Or, use the interface for formatting of primitives.
|
|-
| Name Rename methods XXXPart, not XXXNode| Rename methods to be XXXPart, for example as writeCompositeMessagePart, instead of writeCompositeMessageNode.
|
|-
| fail* Wrap failso that is throws expection right away| Wrap all instances of * Move fail with IntegrationException.statements from bottom to top, remove else clauses
|
|-
| Override JSONParseparse()| * Override parse method of JSONParser in the JSONMessageParser class. Do this to avoid changing JSONParser.always return a TransferObject
|
|-
| Use parsing primitive formatter when reading.values| When reading information in from a stream in the formatter, use * Use primitive formatter to determine the correct format of a primitive.on values that are parsed before storing them
|
|}
 
===== JSONMessageFormatter =====
1
edit