Vbala
Joined 9 September 2007
Welcome to Vijey's Page
My Name's Vijey; I am currently in the seventh semester of BSD and enrolled in DPS909.
Lab Notes
- The diff file that was generated after the changes were made to tabBrowser.xml.
- The changes were made to open a new tab in between tabs rather than having it opening at the end like it usually does.
Index: tabbrowser.xml =================================================================== RCS file: /cvsroot/mozilla/browser/base/content/tabbrowser.xml,v retrieving revision 1.243 diff -u -8 -p -r1.243 tabbrowser.xml --- tabbrowser.xml 18 Sep 2007 00:59:41 -0000 1.243 +++ tabbrowser.xml 15 Oct 2007 22:15:13 -0000 @@ -1088,17 +1088,17 @@ if (!bgLoad) { function selectNewForegroundTab(browser, tab) { browser.selectedTab = tab; } setTimeout(selectNewForegroundTab, 0, getBrowser(), tab); } if (!bgLoad) this.selectedTab = tab; - + var position = currentTabIndex + 1; return tab; ]]> </body> </method> <method name="loadTabs"> <parameter name="aURIs"/> <parameter name="aLoadInBackground"/> @@ -1173,17 +1173,18 @@ t.maxWidth = this.mTabContainer.mTabMaxWidth; t.minWidth = this.mTabContainer.mTabMinWidth; t.width = 0; t.setAttribute("flex", "100"); t.setAttribute("validate", "never"); t.setAttribute("onerror", "this.parentNode.parentNode.parentNode.parentNode.addToMissedIconCache(this.getAttribute('image')); this.removeAttribute('image');"); t.className = "tabbrowser-tab"; - this.mTabContainer.appendChild(t); + var currentTabIndex = this.mTabContainer.selectedIndex; + this.mTabContainer.insertBefore(t, this.mTabContainer.childNodes.item(currentTabIndex + 1)); if (document.defaultView .getComputedStyle(this.mTabContainer, "") .direction == "rtl") { /* In RTL UI, the tab is visually added to the left side of the * tabstrip. This means the tabstip has to be scrolled back in * order to make sure the same set of tabs is visible before and * after the new tab is added */ @@ -1952,17 +1953,17 @@ this.mTabListeners.splice(aIndex, 0, this.mTabListeners.splice(aTab._tPos, 1)[0]); var oldPosition = aTab._tPos; aIndex = aIndex < aTab._tPos ? aIndex: aIndex+1; this.mCurrentTab._selected = false; // use .item() instead of [] because dragging to the end of the strip goes out of // bounds: .item() returns null (so it acts like appendChild), but [] throws - this.mTabContainer.insertBefore(aTab, this.mTabContainer.childNodes.item(aIndex)); + this.mTabContainer. Before(aTab, this.mTabContainer.childNodes.item(aIndex)); // invalidate cache, because mTabContainer is about to change this._browsers = null; var i; for (i = 0; i < this.mTabContainer.childNodes.length; i++) { this.mTabContainer.childNodes[i]._tPos = i; this.mTabContainer.childNodes[i]._selected = false; }
FSOSS REPORT FOR DPS909
Introduction The two talks I decided to write about which I attended in the FS0SS 2007 gathering were Benjamin Smedberg’s Open source code review and Mike Beltzner’s talk on Designing for and with a community.
Benjamin Smedberg's Open source code review
Focusing on the first talk that I attended; Benjamin Smedberg’s key main reasons behind code reading were as follows:
- Identifying Bugs
- Identifying and implementing features
- Creating documentation or revising documentation that is available for the code
- Understanding how the code works
- And the last and according to Mr.Smedberg the most hardest part of it all; keeping track of the patches or understanding what patches have been done on the software by other people in the community
Contact Info
vbalasun@learn.seneac.on.ca or vijeybala@gmail.com