Difference between revisions of "Cue Times"
(→Vince: added peer review column) |
(→Tests: trying to change my table to markdown but feeling) |
||
| Line 33: | Line 33: | ||
=== Dale === | === Dale === | ||
URL to git repo with tests: https://github.com/daliuss/webvtt/tree/cueTimeTests/test/spec | URL to git repo with tests: https://github.com/daliuss/webvtt/tree/cueTimeTests/test/spec | ||
| + | {| border="1" | ||
| + | |- | ||
| + | |class="header"|'''Filename''' | ||
| + | |class="header"|'''Description''' | ||
| + | |class="header"|'''Should Pass / Fail?''' | ||
| + | |class="header"|'''Reasoning''' | ||
| + | |class="header"|'''Creation Note''' | ||
| + | |class="header"|'''Comments''' | ||
| + | |class="header"|'''Peer Review''' | ||
| + | |- | ||
| + | |cuetime_bareminimum.vtt | ||
| + | |Bare minimum file that passes (no cue content) | ||
| + | |Pass | ||
| + | |Conforms to spec | ||
| + | |ST2 | ||
| + | | | ||
| + | | | ||
| + | |- | ||
| + | |cuetime_bareminimum_content.vtt | ||
| + | |Bare minimum file that passes (cue content) | ||
| + | |Pass | ||
| + | |Conforms to spec | ||
| + | |ST2 | ||
| + | | | ||
| + | | | ||
| + | |- | ||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
| − | |||
=== Vince === | === Vince === | ||
I'm gonna remake the table using markdown. Hitting <td></td> is tedious | I'm gonna remake the table using markdown. Hitting <td></td> is tedious | ||
| Line 121: | Line 78: | ||
| | | | ||
| | | | ||
| − | |||
| | | | ||
|- | |- | ||
| Line 130: | Line 86: | ||
| | | | ||
| | | | ||
| − | |||
| | | | ||
|- | |- | ||
| Line 139: | Line 94: | ||
| | | | ||
|Took out the --> | |Took out the --> | ||
| − | |||
| | | | ||
|- | |- | ||
| Line 148: | Line 102: | ||
| | | | ||
| | | | ||
| − | |||
| | | | ||
|- | |- | ||
| Line 157: | Line 110: | ||
| | | | ||
| | | | ||
| − | |||
| | | | ||
|- | |- | ||
| Line 166: | Line 118: | ||
| | | | ||
| | | | ||
| − | |||
| | | | ||
|- | |- | ||
'''TODO:''' Break hour, see if days work, create multiple cue times that don't make sense (first cue at 2 minutes, second at 1 minute) | '''TODO:''' Break hour, see if days work, create multiple cue times that don't make sense (first cue at 2 minutes, second at 1 minute) | ||
Revision as of 21:21, 25 September 2012
Contents
Group Members
- Vince Lee
- Thevakaran Virutthasalam
- Dale Karp
Test Ideas
- Syntax
- Single cue tests
- Times out of order
- Multiple cue tests
- Nested cues
- Overlapping cues
- Cue times out of order
Testing Procedure
Writing Tests
- Check if the test you have in mind exists already in the wiki
- If not, write your test case file
- When you finish writing, document the test case in the wiki ASAP so you don't forget!
- Commit your test case to the github repo
Peer Review
- Review someone else's test case
- Sign off in the 'Peer Review' column of the table with your name so that we know it's been looked at (TO DO: Create Peer Review column in tables)
Cue Time Syntax Rules
- A WebVTT timestamp representing the start time offset of the cue. The time represented by this WebVTT timestamp must be greater than or equal to the start time offsets of all previous cues in the file.
- One or more U+0020 SPACE characters or U+0009 CHARACTER TABULATION (tab) characters.
- The string "-->" (U+002D HYPHEN-MINUS, U+002D HYPHEN-MINUS, U+003E GREATER-THAN SIGN).
- One or more U+0020 SPACE characters or U+0009 CHARACTER TABULATION (tab) characters.
- A WebVTT timestamp representing the end time offset of the cue. The time represented by this WebVTT timestamp must be greater than the start time offset of the cue.
Tests
Dale
URL to git repo with tests: https://github.com/daliuss/webvtt/tree/cueTimeTests/test/spec
| Filename | Description | Should Pass / Fail? | Reasoning | Creation Note | Comments | Peer Review |
| cuetime_bareminimum.vtt | Bare minimum file that passes (no cue content) | Pass | Conforms to spec | ST2 | ||
| cuetime_bareminimum_content.vtt | Bare minimum file that passes (cue content) | Pass | Conforms to spec | ST2 |
| Filename | Description | Should Pass / Fail? | Reasoning | Creation Note | Comments | Peer Review |
| bad01.vtt | 00:00.000 --> 00:00.000 | Fail | End timestamp must be greater than start timestamp | |||
| bad02.vtt | 00:00.001 --> 00:00.000 | Fail | End timestamp must be greater than start timestamp | |||
| bad03.vtt | 00:00.000 00:00.001 | Fail | Timestamp separator not found | Took out the --> | ||
| bad04.vtt | 00:00.0000 --> 00:00.001 | Fail | Milliseconds must be 3 digits | |||
| bad05.vtt | 00:000.000 --> 00:00.001 | Fail | Seconds should be 2 digits | |||
| bad06.vtt | 000:00.000 --> 00:00.001 | Fail | Minutes should be 2 digits |
