Difference between revisions of "User:Mikey/project2"
(→Project Contributor(s)) |
(→Project News) |
||
| (5 intermediate revisions by the same user not shown) | |||
| Line 9: | Line 9: | ||
== Project Contributor(s) == | == Project Contributor(s) == | ||
| + | |||
| + | Nobody yet : [http://mikey-osd600a.blogspot.com/2009/11/week-10-try-out-my-patch-please.html Test out my patch on Thunderbird & SeaMonkey. ] | ||
== Project Details == | == Project Details == | ||
| Line 18: | Line 20: | ||
[https://bug286760.bugzilla.mozilla.org/attachment.cgi?id=413868 0.2 Release]: In the end, I did not use the TRIM_WHITESPACE() macro, because of my small understanding of how it works. Just a little bit of code is added to the msg_quote_phrase_or_addr() function. This bit of code removes trailing spaces from the address given. However, I might be at fault, because this code might not be allowed due to some RFC regulations. | [https://bug286760.bugzilla.mozilla.org/attachment.cgi?id=413868 0.2 Release]: In the end, I did not use the TRIM_WHITESPACE() macro, because of my small understanding of how it works. Just a little bit of code is added to the msg_quote_phrase_or_addr() function. This bit of code removes trailing spaces from the address given. However, I might be at fault, because this code might not be allowed due to some RFC regulations. | ||
| + | |||
| + | [https://bug286760.bugzilla.mozilla.org/attachment.cgi?id=416382 Updated patch with corrections]: After submitting my first patch, I received valuable remarks from a commentator. He told me to fix few nits in my code: changing the data type of a variable, removing another variable, changing the length of my indentations, and the location of my space and my bracket. These changes were fixed in my patch. Currently, a reviewer has chosen to look at my patch. | ||
Latest revision as of 13:25, 7 December 2009
Contents
Project Name
Bug 286760 - Ending a mail address with a space in address book displays it wrong when composing
Project Description
This project involves fixing a problem with saved email addresses ending with trailing spaces in the address book causing sent messages to be lost. For example, the user will enter a new contact entry with an email address followed by a space, such as "test@example.com " (minus the quotes) and saves it. In the compose window, they will select the email address that they just saved and send their message, but this message will not be delivered to the recipient.
Project Leader(s)
Project Contributor(s)
Nobody yet : Test out my patch on Thunderbird & SeaMonkey.
Project Details
After running the test with additional test cases, I found that the trailing spaces given in the email address are not discarded when the email address is concatenated with the full name of the contact. For example, if the name of the contact is John Doe and the email address of the contact is "jdoe@example.com " (minus the quotes)(take note of the trailing space), the result would give "John Doe <jdoe@example.com >" (minus the quotes)(including the trailing space).
My take on this is to remove the trailing spaces before the result is returned from the msg_quote_phrase_or_addr(...). I plan on using the macro, TRIM_WHITESPACE(...), to do this.
Project News
0.2 Release: In the end, I did not use the TRIM_WHITESPACE() macro, because of my small understanding of how it works. Just a little bit of code is added to the msg_quote_phrase_or_addr() function. This bit of code removes trailing spaces from the address given. However, I might be at fault, because this code might not be allowed due to some RFC regulations.
Updated patch with corrections: After submitting my first patch, I received valuable remarks from a commentator. He told me to fix few nits in my code: changing the data type of a variable, removing another variable, changing the length of my indentations, and the location of my space and my bracket. These changes were fixed in my patch. Currently, a reviewer has chosen to look at my patch.
