Difference between revisions of "CueSettingsTests"
(→Size) |
(→Cue Settings Tests) |
||
Line 48: | Line 48: | ||
00:11.000 --> 00:13.000 position10% | 00:11.000 --> 00:13.000 position10% | ||
− | *':' missing in between cue and value | + | *':' missing in between cue setting and value |
Line 55: | Line 55: | ||
00:11.000 --> 00:13.000 position:10 | 00:11.000 --> 00:13.000 position:10 | ||
*'%' missing at the end | *'%' missing at the end | ||
+ | |||
=== Size === | === Size === | ||
Line 67: | Line 68: | ||
00:11.000 --> 00:13.000 size:A% | 00:11.000 --> 00:13.000 size:A% | ||
− | * | + | *character above utf-8+0039 |
+ | **NOTE: the parser currently passes this test instead of failing it | ||
Line 73: | Line 75: | ||
00:11.000 --> 00:13.000 size:+% | 00:11.000 --> 00:13.000 size:+% | ||
+ | *character below utf-8+0030 | ||
+ | **NOTE: the parser currently passes this test instead of failing it | ||
Line 78: | Line 82: | ||
00:11.000 --> 00:13.000 size10% | 00:11.000 --> 00:13.000 size10% | ||
+ | *':' missing in between cue setting and value | ||
Line 83: | Line 88: | ||
00:11.000 --> 00:13.000 size:10 | 00:11.000 --> 00:13.000 size:10 | ||
+ | *'%' missing at the end | ||
+ | |||
=== Align === | === Align === | ||
Line 89: | Line 96: | ||
00:11.000 --> 00:13.000 :start | 00:11.000 --> 00:13.000 :start | ||
+ | *no cue setting | ||
Line 94: | Line 102: | ||
00:11.000 --> 00:13.000 align:start | 00:11.000 --> 00:13.000 align:start | ||
+ | *positive test (should succeed) | ||
Line 99: | Line 108: | ||
00:11.000 --> 00:13.000 align:middle | 00:11.000 --> 00:13.000 align:middle | ||
+ | *positive test (should succeed) | ||
Line 104: | Line 114: | ||
00:11.000 --> 00:13.000 align:end | 00:11.000 --> 00:13.000 align:end | ||
+ | *positive test (should succeed) | ||
Line 109: | Line 120: | ||
00:11.000 --> 00:13.000 align:star | 00:11.000 --> 00:13.000 align:star | ||
+ | *test misspelling of one of the possible values | ||
Line 114: | Line 126: | ||
00:11.000 --> 00:13.000 align: | 00:11.000 --> 00:13.000 align: | ||
+ | *test missing value |
Revision as of 09:51, 21 September 2012
Cue Settings Tests
Hi Caitlin here are the tests I've come up with so far for the position, size and align cue settings. I have a few concerns about some of the things I saw in the parser so if you could help me test them it would be great.
Some notable things I've discovered:
- 00:11.000 --> 00:13.000position:10% passes
- there is no space between the cue setting and the cue timing, do you know if this is necessary for the parser or not?
- 00:11.000 --> 00:13.000 position:A% passes
- any character besides ' ' (space) between : and % will pass. This looks to me like a bug but I'd like to see if anyone else has found this to happen
A few things to note about the tests:
- The first test for position is the absence of the cue setting tag, I think technically this test should work for the rest of the tests that use the :n% format as well hence its absence in the size tests.
- I have a test for each cue setting type where the ':' is missing, what do you think about this? I have been thinking that only one for all the cue settings would be enough as this simply tests the parser for whether it can split setting from value.
Position
WEBVTT
00:11.000 --> 00:13.000 :10%
- no cue setting
WEBVTT
00:11.000 --> 00:13.000 position:10%
- positive test (should succeed)
WEBVTT
00:11.000 --> 00:13.000 position:A%
- character above utf-8+0039
- NOTE: the parser currently passes this test instead of failing it
WEBVTT
00:11.000 --> 00:13.000 position:+%
- character below utf-8+0030
- NOTE: the parser currently passes this test instead of failing it
WEBVTT
00:11.000 --> 00:13.000 position10%
- ':' missing in between cue setting and value
WEBVTT
00:11.000 --> 00:13.000 position:10
- '%' missing at the end
Size
WEBVTT
00:11.000 --> 00:13.000 size:10%
- positive test (should succeed)
WEBVTT
00:11.000 --> 00:13.000 size:A%
- character above utf-8+0039
- NOTE: the parser currently passes this test instead of failing it
WEBVTT
00:11.000 --> 00:13.000 size:+%
- character below utf-8+0030
- NOTE: the parser currently passes this test instead of failing it
WEBVTT
00:11.000 --> 00:13.000 size10%
- ':' missing in between cue setting and value
WEBVTT
00:11.000 --> 00:13.000 size:10
- '%' missing at the end
Align
WEBVTT
00:11.000 --> 00:13.000 :start
- no cue setting
WEBVTT
00:11.000 --> 00:13.000 align:start
- positive test (should succeed)
WEBVTT
00:11.000 --> 00:13.000 align:middle
- positive test (should succeed)
WEBVTT
00:11.000 --> 00:13.000 align:end
- positive test (should succeed)
WEBVTT
00:11.000 --> 00:13.000 align:star
- test misspelling of one of the possible values
WEBVTT
00:11.000 --> 00:13.000 align:
- test missing value