Open main menu

CDOT Wiki β

Changes

Implementing the Mouse Lock API in Firefox

39,507 bytes added, 23:09, 14 February 2012
→‎Review Issues
* Chris Gosselin (Student, OSD600)
* Anurag Bhatnagar (Student, DPS909, [http://twitter.com/anuragbh @anuragbh])
* Raymond Hung (Wannabe Developer, Student, [http://twitter.com/Raymond_Hung @Raymond_Hung])* Ausley Johnson(Student, DPS909OSD600)
* Jesse Silver (Student, OSD600)
* Ching Wei Tseng(Student, DPS909)
* Abhishek Bhatnagar (Student, [http://twitter.com/abhishekToronto @abhishekToronto])
* Diogo Golovanevsky Monteiro ([http://twitter.com/diogogmt @diogogmt])
* Simon de Almeida(Student) ([http://twitter.com/simon661 @simon661])
* Stanley Tsang (Student, DPS909)
* Denise Rigato (Student, DPS909)
* ''<your name here>''Qian (Ken) Xu (Student, DPS909)* Moussa Tabcharani (Student, DPS909)* Keyan Ren (Student, OSD600)* Joseph Hughes (Student, OSD600)
==Communication==
* IRC discussions: [irc://irc.mozilla.org/seneca #seneca], [irc://irc.mozilla.org/paladin #paladin]
* Questions: ask and answer any questions here: [[Mouse Lock Implementation FAQ]]
* Trackable Work Items: put all sub-items we have to do here https://github.com/humphd/mozilla-central/issues
* Blog Series: http://vocamus.net/dave/?cat=28
==Tasks==
 
===Getting Started===
# Clone our repo and build a debug version locally
# Blog about your work on this implementation
# Add questions/answers to [[Mouse Lock Implementation FAQ]]
 
===High-Level Mouse Lock Implementation Tasks===
 
====Implementation====
 
# <s>No mouse cursor is displayed when the mouse is locked</s> - rhung
# <s>MouseLockable DOM Implementation, navigator.pointer ([[Notes on MouseLock DOM Implementation Nov 13, 2011]])</s> - humph
## <strike>[[void lock (in Element target, optional in VoidCallback successCallback, optional in VoidCallback failureCallback);]]</strike> diogogmt, humph
## <strike>void unlock ();</strike> humph, diogogmt
## <strike>bool islocked ();</strike> - humph
# <strike>Mouse Lock Platform Implementations</strike> JSilver999, humph
## <strike>Windows: [http://msdn.microsoft.com/en-us/library/windows/desktop/ms648394%28v=vs.85%29.aspx SetCursorPos(x, y)]</strike>
## <strike>OS X [http://www.cocoabuilder.com/archive/cocoa/77124-setting-cursor-position.html CGWarpMouseCursorPosition(CGPointMake(x, y))]</strike>
## <strike>Linux (GTK) [http://www.gtkforums.com/viewtopic.php?t=182 gdk_display_warp_pointer (display, screen, x, y)], add to http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp ???</strike>
## Mobile?
# <strike>Investigate whether we can get movement information directly from OS</strke> - northWind
# <s>mouselocklost event DOM Implementation</s> - diogogmt
# <s>Extend MouseEvent DOM implementation with movementX, movementY</s> - humph, JSilver999
## <s>[[Stack Trace for nsDOMMouseEvent::nsDOMMouseEvent ctor]] (created on mouse move)</s>
## <s>[[Stack Trace for nsDOMMouseEvent::GetScreenX]]</s>
## <s>[[Where to store the state info (e.g., previous position) between mouse events?]]</s>
# <s>The browser must exit the mouse lock state if the user agent, window, or tab loses focus</s> - diogogmt
# <strike>Fixup NULLs being returned from lock() C++ implementation, should be NS*</strike> - Anachid
# <strike>Mouse lock should only work when in Full Screen Mode</strike> - diogogmt, rhung
# <strike>[[Refactor nsIDOMNavigator changes for pointer attribute to be in separate interface]]</strike> humph
# <strike>Do we need to do conditional compilation for mouse lock?</strike> humph (not going to bother for now)
# <strike>When mouse lock is enabled clientX, clientY, screenX, and screenY must hold constant values as if the mouse did not move at all once mouse lock was entered.</strike> humph
# <s>Freeze mouse pointer in centre of window when mouse lock is enabled (e.g., moving the mouse causes an event, but forces the mouse to go back to the original position).</s> - JSilver999
# <strike>"Events that require the concept of a mouse cursor must not be dispatched (for example: mouseover, mouseout)"</strike> - humph
# <strike>Figure out [[Mac Crash with Jesse's SynthesizeMouseMove change]]</strike> humph
# <strike>When the locked element is removed from the DOM Tree, the mouse should be unlocked</strike> diogogmt
# <strike>Save the screenX and screenY position before locking the mouse.</strike> - humph
# <strike>Reset the mouse position back to the original position when unlocking.</strike> - humph
# <s>"When unlocked, the system cursor can exit and re-enter the user agent window. If it does so and the user agent was not the target of operating system mouse move events then the most recent mouse position will be unknown to the user agent and movementX/Y can not be computed and must be set to zero"</s> diogogmt
# <s>Trying to lock a locked element should fire the success callback</s> CloudScorpion
# <s>Before locking the mouse check if the element is a DOM element and if it is in the DOM Tree</s> diogogmt
# <s>Fix accurateness of mouse positioning on unlock() (should be the same point as when lock() was called). Currently works, but is offset. See nsEventStateManager::SetMouseLock. </s> JSilver999
# <s>Restructure Lock method to do most of its operations in a separate thread.</s> humph
# <s>Fix license headers for new files to use proper [http://www.mozilla.org/MPL/boilerplate-1.1/ MPL boilerplate]</s> humph
# <s>Do we need to add a user pref to enable/disable mouse lock? Nice to have, not blocking.</s> northwind, mjschranz
# "Once mouse lock is acquired, stop mouse events from being fired to other elements that are not locked (e.g., only fire to locked element)." Only the fullscreen element will get events. Need advice in review on how to do this properly.
 
=====Out of Scope Implementation=====
 
Because we are only implementing Mouse Lock for Fullscreen elements, some aspects of the spec can/must be put off until later. Other items below are simply not in scope for this first round of implementation.
 
# The ESC key should exit mouse lock. This will currently exit fullscreen, and therefore mouse lock - diogogmt
# "User agents may prompt for confirmation before locking, this preference may be saved as a content setting" How to deal with this? What UI do we use? See also, "Repeated escapes of mouse lock can signal user agent to not re-lock the mouse without more specific user intent gesture, e.g. similar to how Chrome suppresses repeated alert() calls"
# "The Mouse Lock API must exit the mouse lock state if the user agent, window, or tab loses focus"
# Clip the mouse so it doesn't leave the locked element with a mouse movement large enough to exceed its bounds. See:
## [http://msdn.microsoft.com/en-us/library/windows/desktop/ms648383%28v=vs.85%29.aspx ClipCursor] on Windows
## [http://developer.apple.com/library/mac/#documentation/GraphicsImaging/Reference/Quartz_Services_Ref/Reference/reference.html CGAssociateMouseAndMouseCursorPosition and CGGetLastMouseDelta] on OS X
## [http://www.x.org/archive/X11R6.8.2/doc/XGrabPointer.3.html XGrabPointer] on Linux
 
====Review Issues====
 
* <s>Rewrite DOM node removal unlocking logic to use nsIMutatationObserver</s> humph, diogogmt
* <s>Space, bracing, tabs, etc style nits</s> humph
* <s>clientX, clientY, screenX, screenY values should follow spec as per [https://bugzilla.mozilla.org/show_bug.cgi?id=633602#c55 scheib's comment]</s> diogogmt
* <s>Confirm |aEvent->lastRefPoint = nsIntPoint(bounds.width/2, bounds.height/2);| that / 2 is right</s> diogogmt
* <s>"nsCOMPtr<nsIContent> mMouseLockedElement; - Shouldn't this be a static member variable? Or how does the patch handle cases when the document which has iframe and mouse moves over those iframes." Probably wants a test for this case, too.</s> diogogmt
* <s>"nsDOMMouseLockable::ShouldLock...QI to nsINode and check IsInDoc()"</s> diogogmt
* <s>"nsRefPtr<nsMouseLockableRequest> request = new nsMouseLockableRequest(aSuccessCallback, aFailureCallback); -- You should store aTarget (QI'ed to nsINode or nsIContent or Element or nsIDOMEventTarget) so that when calling callback you push Cx to stack; nsCxPusher pusher: // defined in nsContentUtils.h NS_ENSURE_STATE(pusher.Push(target));"</s> - humph
* <s>"nsDOMMouseLockable looks like it should be cycle collectable"</s> humph
* <s>Break .pointer out of Navigator, and add nsIDOMMozNavigatorPointer (not sure if this name is best) as a new interface to Navigator, similar to nsIDOMMozNavigatorBattery.</s> - humph, diogogmt
* <s>Rename for moz* prefix. The API should be probably prefixed. So, navigator.mozPointer and all the interfaces should start with nsIDOMMoz. Similar to what webkit* is doing:</s> - humph
** <s>navigator.webkitPointer.unlock();</s>
** <s>navigator.webkitPointer.lock();</s>
** <s>navigator.webkitPointer.isLocked();</s>
** <s>document.body.addEventListener("webkitpointerlocklost", ...</s>
** <s>mouseMoveEvent.webkitMovementX</s>
** <s>mouseMoveEvent.webkitMovementY</s>
* Follow discussion unfolding here for other changes: http://lists.w3.org/Archives/Public/public-webapps/2011OctDec/1558.html
* Finish tests, updated to changes above.
* <s>Update patch to trunk</s> - humph
* Figure out why DOMMouseScroll events aren't being retargeted to the locked element
 
* Look into roc's suggestion from bug 722449 comment 8, namely, using getBoundingClientRect vs. GetPrimaryFrame()
 
* Maybe use nsStubMutationObserver instead of nsIMutationObserver?
 
* Extensions to the Document Interface. Add pointerLockElement attribute and exitPointerLock method - diogogmt
 
* Update Element interface to have requestPointerLock - diogogmt
 
* <s>Dispatch pointerlockchange or pointerlockerror events instead of firing a callback when pointer gets locked</s> - diogogmt
 
* Update mochitests to use new pointerlock API
 
* Add expect number of tests to mochitests
* Update patch to trunk
 
===Tests===
 
The central repo with all the tests are located [https://github.com/rhung/mozilla-central/tree/mouselock-tests here]. For more information on how to make mochitests and how to send the pull request to the appropriate person, check out the [http://zenit.senecac.on.ca/wiki/index.php/Mochitest_FAQ Mochitest FAQ] List tests we need below:
{| border=1 style="border: 1px solid darkgray;"
|Id
|Description
|Test Author(s)
|Test File
|-
|1
|<s>"there is no limit to how far movement can go...not limited by screen boundaries" -- mouse lock should mean infinite movement in the X and Y axes...There will be no limit to movementX/Y values if the mouse is continuously moved in a single direction"</s>
|'''hchun'''
|'''file_limitlessScroll.html'''
|-
|2
|<s>"The concept of the mouse cursor will have been removed, and it will not move off the window or be clamped by a screen edge"</s>
|'''hchun'''
|'''file_limitlessScroll.html'''
|-
|3
|"no mouse cursor is displayed" -- mouse cursor should be hidden while locked
|'''dvillase'''
|-
|4
|<s>navigator.pointer (readonly) is a MouseLockable</s>
|<strong>abhatnagar</strong>
|'''test_navigatorPointer.html'''
|-
|5
|<s>MouseLockable has lock(), unlock(), islocked()</s>
|<strong>abhatnagar</strong>
|'''test_mouseLockableHasRequiredMethods.html'''
|-
|6
|<s>islocked() returns true if mouse is locked, false if not locked</s>
|<strong>JSilver999</strong>
|'''file_fullscreen.html'''
|-
|7
|<s>lock(target) expects a DOM element, and takes two optional callbacks: successcallback, failurecallback.</s>
|<strong>JSilver999</strong>
|'''file_fullscreen.html'''
|-
|8
|<s>lock() should return immediately and call callbacks when lock succeeds or fails</s>
|<strong>JSilver999</strong>
|'''file_fullscreen.html'''
|-
|9
|"Mouse lock must succeed only if the window is in focus"
|'''johnno'''
|
|-
|10
|"Mouse lock must succeed only if...the user-agent is the active application of the operating system"
|'''johnno'''
|
|-
|11
|<s>"The target of lock need not be in focus"</s>
|'''johnno'''
|'''file_targetOutOfFocus.html'''
|-
|12
|<s>"Mouse lock must succeed only if the target is in the DOM tree"</s>
|'''Anachid'''
|'''file_DOMtree.html'''
|-
|13
|<s>"If the target is removed from the DOM tree after mouse lock is entered then mouse lock will be lost."</s>
|'''Anachid'''
|'''file_DOMtree.html'''
|-
|14
|<s>"If the mouse is already locked to the same element, a repeated call to lock will succeed and the successCallback called"</s>
|'''jboelen'''
|'''test_doubleLockCallBack.html'''
|-
|15
|<s>"If another element is locked [and lock() is called] a user agent must transfer the mouse lock to the new target and call the mouselocklost callback for the previous target"</s>
|'''jboelen'''
|'''DEFUNCT'''
|-
|16
|<s>"The Mouse Lock API must provide a default system action to unlock the mouse" namely ESC.</s>
|'''CloudScorpion'''
|'''file_defaultUnlock.html'''
|-
|17
|<s>"Once in the locked state the user agent must fire all relevant user generated MouseEvent events (for example: mousemove, mousedown, mouseup, click, wheel)[DOM-LEVEL-3-CORE] to the target of mouse lock, and not fire mouse events to other elements"</s>
|'''rhung'''
|'''file_MouseEvents.html'''
|-
|18
|<s>"Events that require the concept of a mouse cursor must not be dispatched (for example: mouseover, mouseout)"</s>
|'''rhung'''
|'''file_MouseEvents.html'''
|-
|19
|"Movement and button presses of the mouse must not cause the window to lose focus" -
|-
|20
|<s>"Synthetic mouse events created by application script act the same regardless of lock state"</s>
|'''Tentacle'''
|'''file_syntheticMouseEvent.html'''
|-
|21
|<s>"The unlock method cancels the mouse lock state"</s>
|'''abhatnagar1'''
|No test written for this case specifically but '''file_fullscreen.html''' covers it.
|-
|22
|"[Upon unlock() t]he system mouse cursor must be displayed again and positioned at the same location that it was when mouse lock was entered (the same location that is reported in screenX/Y when the mouse is locked)"
|'''dvillase'''
|-
|23
|<s>"When mouse lock is lost or disabled for any reason user agents must fire an event named mouselocklost with its bubble attribute set to true to the mouse lock target element"</s>
|'''stsang'''
|'''file_mouselocklost.html'''
|-
|24
|<s>MouseEvent must contain (readonly) movementX and movementY</s>
|'''KeyR, JSilver999'''
|'''file_movement.html'''
|-
|25
|<s>"The members movementX and movementY must provide the change in position of the mouse, as if the values of screenX/Y were stored between two subsequent mousemove events eNow and ePrevious and the difference taken movementX = eNow.screenX-ePrevious.screenX"</s>
|'''KeyR, JSilver999'''
|'''file_movement.html'''
|-
|26
|<s>"movementX/Y must be valid regardless of mouse lock state"</s>
|'''KeyR, JSilver999'''
|'''file_movement.html'''
|-
|27
|<s>"When unlocked, the system cursor can exit and re-enter the user agent window. If it does so and the user agent was not the target of operating system mouse move events then the most recent mouse position will be unknown to the user agent and movementX/Y can not be computed and must be set to zero"</s>
|'''moussa1'''
|'''test_mousePos.html'''
|-
|28
|<s>"When mouse lock is enabled clientX, clientY, screenX, and screenY must hold constant values as if the mouse did not move at all once mouse lock was entered"</s>
|'''jbraffoul'''
|'''file_constantxy.html'''
|-
|29
|<s>"The Mouse Lock API must exit the mouse lock state if the user agent, window, or tab loses focus"</s>
|'''drigato'''
|'''test_exitMouselockOnLoseFocus.html'''
|-
|30
|Test to make sure that mouse lock only occurs when an element is in full screen mode (not F11 or done via the menus). This includes:
# Switching focus to another window
|'''jsiu3'''
|-
|31
|<s>Tests for mouselocklost event</s>
|'''stsang'''
|'''file_mouselocklost.html'''
|-
|32
|<s>Test to make sure that mouse is unlocked when page is unloaded.</s>
|'''northWind'''
|'''file_unlockOnUnload.html'''
|-
|}
 
====Reviewing Tests====
 
There are a series of common mistakes in the tests that need to get fixed. Here are some of them:
 
# Need to clean-up tabs vs. spaces and indentation issues (2-spaces per tab) in many test files. Use https://github.com/einars/js-beautify. [https://github.com/rhung/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/mouselock/test_userPref.html This is a test that is formatted correctly], in terms of indentation and spaces vs. tabs.
# No line of code should be 80 characters or longer--break them so they are under 80
# No Windows end-of-lines, use Unix end-of-lines
# No whitespace at the end of a line
# Run your test code through http://www.jshint.com/. Note, it will complain about unknown globals like SimpleTest. Make sure the rest of the JavaScript is good.
# Remove unnecessary comments. Only things that explain the test.
# If you need constants, use const instead of var
# Don't use variables if they aren't needed. For example, don't introduce a variable to store a value, only to pass it into ok() or is(). Just test the expression in ok() or is().
# Make sure your JavaScript follows proper naming: goodVariableName, bad_variable_name, badvariablename;
# Tests should follow the template as closely as makes sense: http://pastebin.com/vxmsepVh
# Tests should include a simple comment block describing what is being tested
# Only use <code>SimpleTest.waitForFocus()</code> if you really need it.
# Be consistent with "..." vs. '...' for strings. Pick one and use it throughout the file.
# Remove <code>console.log()</code>
# Prefer <code>document.body</code> to <code>document.getElementsByTagName('body')[0]</code>
# Braces on the same line: <code>if (...) {\n</code> and <code>} else {\n</code>
# An error message for is() or ok() of "Error message" is not acceptable. Make sure you understand the failure.
# If you need to actually lock the mouse, you'll need <code>SpecialPowers.setBoolPref("full-screen-api.allow-trusted-requests-only", false);</code> to allow non-user initiated fullscreen mode (i.e., normally it requires a user to click a button or trigger some other event).
# If you're testing that variable foo or expression fooFunction() are true, use ok(), not is(): <code>ok(foo, "Error message if not true.");</code> or <code>ok(fooFunction(), "Error message if function returns false");</code>. Don't do <code>is(foo, true, "Error message if false.");
# Make sure code that relies on things happening in asynchronous code gets called in a callback or event handler, not on the next line. For example, if you call navigator.pointer.lock(), you can't check navigator.pointer.islocked() on the next line, you need to use the successCallback/errorCallback. Same for focus or blur calls and events. Actions that trigger something happening in the future often need a callback or event handler.
# Prefer <code>i++;</code> to <code>i+=1;</code>
# Many tests require the harness and focus, ensure that those tests are correctly written ie:
#* For Harness: See [[#Using the Test Harness]]
#* For Focus: See [[#Waiting For Focus]]
 
One or more tests have to deal with switching the lock between multiple elements, and the [[Changes to Fullscreen Unlock|spec is changing]] on that front.
 
====New Test Reviews [Updated 1/19/2012]====
This is a new list of test. The following tests will need to confirm to the new prefixes in accordance to Patchv3 of [https://bugzilla.mozilla.org/show_bug.cgi?id=633602 Bug 633602]. Please add your name beside each test(s) you are assessing/reviewing/fixing/peer reviewing.
Once the cause for rejection is clear, indicate it by placing an X in any of the columns and optionally filling out the comments column. Indicate the action taken to resolve the issue in the action taken column. Example actions include:
# '''DELETED'''
# '''FIXED'''
 
Other actions are also acceptable where appropriate.
Once fixed, please pull request to rhung's [https://github.com/rhung/mozilla-central/tree/mouselock-tests/dom/tests/mochitest/mouselockrhung's mouselock-tests] branch and indicate that you've done so in the pull requested column. Ensure that you add '''[POST-SUBMIT]''' to the name of your pull request.
 
{| border=1 style="border: 1px solid darkgray;"
| Num
| Name
| Primary Reviewer
| Timing issues?
| Needs Harness?
| Needs focus?
| Formatting issues?
| Other? (Indicate in comments)
| Peer Reviewers
| Peer reviewed?
| Action Taken
| Pull requested?
| bgcolor="red" style="text-align:center;" | Updated with Patchv3
| Comments
|-
| colspan=14 bgcolor="yellow" style="text-align:center;" | '''Ensure you have actually tested your test before sending a pull request'''
|-
| 1
| test_FullScreenHarness.html
| Anachid
| X (no action)
| X (no action)
| X (no action)
| X (no action)
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 2
| file_DOMtree.html
| Anachid
| X (fixed)
| X (fixed)
| X (fixed)
| X (no action)
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 3
| file_nestedFullScreen.html
| Anachid
| X (fixed)
| X (fixed)
| X (fixed)
| X (no action)
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 4
| file_differentDOM.html
| Anachid
| X (no action)
| X (no action)
| X (no action)
| X (no action)
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 5
| file_fullscreen.html
| Anachid
| X
| X
| X
| X
| -
|
|
| '''FIXED'''
|
| X
| Test needs to completely re-done. Cases like <br>
* ok(false, "Mouse locked without fullscreen mode"); will always fail!
* Flow of the test will causes scope problems.
* Currently fixing.
|-
| 6
| file_doubleLockCallBack.html
| Anachid
| X
| X
| X
| X
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 7
| file_unlockOnUnload.html
| Anachid
| X
| X
| X
| X
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 8
| file_exitMouseLockOnLoseFocus.html
| Anachid
| X
| X
| X
| X
| -
|
|
| '''FIXED'''
|
| X
|
|-
| 9
| test_mousePos.html
| rhung
|
|
|
|
| Doesn't seem like it can be done via mochitest
|
|
| '''REMOVED'''
|
|
| As mentioned in the previous comments, synthesizeMouse cannot be moved beyond the browser. It might need to be a litmus test.
|-
| 10
| file_mouselocklost.html
| Anachid
| X
| X
| X
| X
| -
|
|
| '''FIXED'''
|
| X
| Removed some test that were repeating. Otherwise, it works
|-
| 11
| file_movementXY.html
| rhung
| X
| X
| X
| X
| -
|
|
| '''Fixing'''
|
| X
|
|-
| 12
| file_targetOutOfFocus.html
| rhung
| X
| X
| X
| X (fixed)
| -
|
|
| '''FIXED'''
|
| X
| Minor changes, mostly styling.
|-
| 13
| test_mouseLockable.html
| rhung
| X
| X
| X
| X
| -
|
|
| '''FIXED & RENAMED'''
|
| X
| Updated to test_MozPointerLock.html
|-
| 14
| file_MouseEvents.html
| rhung
| X
| X
| X
| X
| Leak issue might be platform specific.
|
|
| '''FIXED?'''
|
| X
| Works without chance of hanging or random success and failures.
|-
| 15
| file_limitlessScroll.html
| rhung
|
|
|
|
|
|
|
| '''MERGED WITH file_movementXY'''
|
|
|
|-
| 16
| file_defaultUnlock.html
| rhung
|
|
|
|
|
|
|
| '''FIXED'''
|
| X
|
|-
| 17
| file_userPref.html
| rhung
|
|
|
|
|
|
|
| '''FIXED'''
|
| X
|
|-
| 18
| file_constantXY.html
| rhung
|
|
|
|
|
|
|
| '''FIXING'''
|
| X
| Needs proper error messages, perhaps formatting issues. Test runs fine though.
|-
|}
 
 
New Tests (not sure if it will work on mochitest, and the test will possibly fail as dave is working on this patch)
# When there is a parent element with multiple child element, have a test to check that all mouse events fired inside the child element are suppressed and is captured by the parent element. (this may also include the scenario where there is an iframe in the parent element)
# A Test to check that repeated move of the mouse to a certain direction that will exceed the screen size does not break the mouselock (this may conflict with file_movementXY.html and we may need to add more test cases)
 
====Changes To Be Applied To Submitted Tests [Deprecated]====
The following table is used to maintain a small note on the task for each test. It will include note from the review by Mozilla and issue we overlooked.
 
 
{| border=1 style="border: 1px solid darkgray;"
| Num
| Test Name
| Reviewer
| Notes
|-
| colspan=4 bgcolor="yellow" style="text-align:center;" | '''Please add your name to the section you want to review and fix'''
|-
|-
| colspan=8 bgcolor="lightgreen" style="text-align:center;" | '''Fill out the Notes section for any issues that are outstanding'''
|-
|1
|test_DOMtree.html
|
|
* northWind Comments:
** Should Delete the element from DOM without exiting fullscreen and then check for pointer.lock instead of the current flow.
|-
|2
|test_MouseEvents.html
|
|
* rhung Comments:
** Should move the tests that require mouselock into the success callback of the lock function.
** Figure out why mouseleave and mouseout tests don't work for Macs.
|-
|3
|
|
|
|-
|}
 
====Remaining Test Reviews [Deprecated]====
The following tests need investigation. Please add your name beside each test(s) you are assessing/reviewing/fixing/peer reviewing.
Once the cause for rejection is clear, indicate it by placing an X in any of the columns and optionally filling out the comments column. Indicate the action taken to resolve the issue in the action taken column. Example actions include:
# '''DELETED'''
# '''FIXED'''
 
Other actions are also acceptable where appropriate.
Once fixed, please pull request to rhung's [https://github.com/rhung/mozilla-central/tree/mouselock-tests/dom/tests/mochitest/mouselockrhung's mouselock-tests] branch and indicate that you've done so in the pull requested column. Ensure that you add '''[POST-SUBMIT]''' to the name of your pull request.
 
{| border=1 style="border: 1px solid darkgray;"
| Num
| Name
| Primary Reviewer
| Timing issues?
| Needs Harness?
| Needs focus?
| Formatting issues?
| Other? (Indicate in comments)
| Peer Reviewers
| Peer reviewed?
| Action Taken
| Pull requested?
| bgcolor="red" style="text-align:center;" | Updated with Patchv3
| Comments
|-
| colspan=14 bgcolor="yellow" style="text-align:center;" | '''Ensure you have actually tested your test before sending a pull request'''
|-
|-
|<s>106</s>
|<s>test_UserAgentIsActive</s>
|<s>diogogmt</s>
|
|<s>X</s>
|
|<s>X</s>
|<s>X</s>
|<s>northwind</s>
|
|<s><b>IMPOSSIBLE IN MOCHITEST</b></s>
|
|
|<s>
* northWind Comments prior to diogo re-writing user agent test:
** navigator.userAgent does not indicate focus status of browser.
** test should be testing for full screen if user agent is in focus then testing that full screen is unavailable when user agent is not in focus.
** test uses tabs, should use spaces.
</s>
|-
|<s>109</s>
|<s>file_doubleLockCallBack.html</s>
|<s>northWind</s>
|
|X
|X
|X
|
|<s>rhung</s>
|X
|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>
|X
|
|
* <s>For Peer Reviewer: https://github.com/rhung/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/mouselock/file_doubleLockCallBack.html</s>
|-
|<s>110</s>
|<s>test_exitMouselockOnLoseFocus.html</s>
|<s>diogogmt</s>
|
|<s>X</s>
|<s>X</s>
|<s>X</s>
|
|<s>northWind</s>
|<s>X</s>
|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>
|
|
|
|-
|114
|test_mousePos.html
|diogogmt
|
|
|
|
|
|
|
|
|
|
|A summary of the test:
*Move the mouse outside the browser boundaries.
*Move the mouse back inside the browser.
*Checks if movementXY were set to zero, since the last refPoint is unknown
The problem is that synthesizeMouse doesn't move the mouse outside the boundaries of the specified element. If the X/Y coords passed to synthesizeMouse are bigger than the X/Y of the element receiving the event, it won't move the cursor.
 
I'm logging all the screen/client/movementXY values, and if the coords passed to synthesizeMouse are bigger than the boundaries of the element receiving the mousemove, the test will break, since the mouse is never moved.
 
 
[http://pastebin.com/MhP62BtC code]
 
|-
|<s>115</s>
|<s>file_mouselocklost.html</s>
|<s>diogogmt</s>
|
|
|
|
|
|<s>rhung</s>
|
|<s><b>PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>
|
|
|<s>Original file didn't need any changes. Passed all test criterias</s>
<s>Awaiting peer review to cross it off the list</s>
|-
|<s>119</s>
|<s>file_fullscreen.html</s>
|<s>northWind</s>
|<s>X</s>
|<s>X</s>
|<s>X</s>
|<s>X</s>
|<s>X</s>
|<s>rhung</s>
|
|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>
|X
|
|<s>Lines</s> <s>49</s>, <s>66</s><s>, and 76 are too long. 76 in particular.</s> <s>Needs comment at the beginning to describe what the test does.</s>
|-
|<s>107</s>
|<s>file_screenXYclientXYConst.html</s>
|<s>diogogmt</s>
|<s>X</s>
|<s>X</s>
|
|
|
|<s>anachid</s>
|
|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>
|
|
|<s>[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests-constantXY/dom/tests/mochitest/mouselock/file_constantXY.html file_constantXY]</s>
<s>[https://github.com/diogogmt/mozilla-central/tree/mouselock-tests-constantXY branch]</s>
 
<s>* Anachid (formatting review on file commit version '''1f5fa3e0a5f7730f33eb5d3f7c51105fac4cb93d'''):</s>
<s>** Line 8 exceeds 80 character limit by 7 characters.</s>
<s>** Remove line 99 [ console.log("start"); ]</s>
<s>** Line 100 and 103 could be re-done to document.getElementById("div") instead of having a div variable, thereby removing variable space and risk of a bug</s>
<s>** Extra line breaks (should be removed) on line 74,77,78</s>
|-
|108
|file_defaultUnlock.html
|diogogmt
|
|
|
|
|
|
|
|
|
|
|
|-
|<s>103</s>
|<s>file_DOMtree.html</s>
|<s>diogogmt</s>
|
|
|
|
|
|<s>rhung</s>
|
|<s><b>FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY</b></s>
|
|
|
|-
|112
|file_limitlessScroll.html
|rhung
|X
|
|
|
|rhung: Needs to be redone to take into account where the mouse currently is rather than sending it a totally new point.
|
|
|'''FIXING'''
|
|
|
|-
|104
|file_MouseEvents.html
|rhung
|X
|
|X
|
|
|northWind
|
|'''PEER REVIEWED, SEE COMMENTS'''
|
|
|
* northWind:
** hangs intermittently, most likely requires focus, see [[#Waiting For Focus|here]]
** 39,41: not required, handled by harness
** 51: remove line, setup being called at better time @343
** 60: should use === for identity as opposed to ==
** 60: should add document.mozFullScreen && to condition
** 61, 69: needs failure callback with is(false, ...) and SimpleTest.finish()
** 68: should add && document.mozFullScreenElement === outer to condition
** 68: whitespace at end of line
** <s>78: looked at this briefly, are we sure that synthMs will cause the cursor to cross over the 'one' div?</s>
** 172: Col 45: "the" should be "a Left"
** 183-214: Why not testing for mousemove?
|-
|116
|file_movementXY.html
|diogogmt
|
|
|
|
|
| mjschranz
|
|<b>REVIEWED, READY FOR PULL REQUEST</b>
|
|
|[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/pointerlock/file_movementXY.html file_movementXY]
* mjschranz
** As far as I can tell, there doesn't appear to be any styling errors. The tests run just fine and based on what I understand about it and what is listed in the comments the tests appear to function as intended.
|-
|<s>120</s>
|<s>file_syntheticMouseEvent.html</s>
|<s>diogogmt</s>
|
|
|
|
|
|<s>rhung</s>
|
|
|
|
|<s>Merged with MouseEvents test</s>
|-
|105
|file_targetOutOfFocus.html
|diogogmt
|
|
|
|
|
| mjschranz
|
|<b>REVIEWED, SEE COMMENTS</b>
|
|
|[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/pointerlock/file_targetOutOfFocus.html file_targetOutOfFocus]
* mjschranz
** Line 41: the word focus is surrounded by single quotation marks, should be double ( "" ).
** No other styling issues seen. Tests run and appear to be functioning as per the specs.
|-
|118
|file_userPref.html
|
|
|
|X
|
|X
|
|
|
|
|
|
|-
|121
|test_mouseLockable.html
(rename to file_mozPointerLock.html)
|
|
|X
|X
|X
|X
|
|
|
|
|
|
|-
|122
|file_nestedFullScreen.html
|diogogmt
|
|
|
|X
|
| mjschranz
|
|<b>REVIEWED, SEE COMMENTS</b>
|
|
|[https://github.com/diogogmt/mozilla-central/blob/mouselock-tests/dom/tests/mochitest/pointerlock/file_nestedFullScreen.html file_nestedFullScreen]
* mjschranz
** Line 48: isLocked method call is missing opening/closing brackets. The test still passes when FullScreenHarness is run however we obviously need to fix that and ensure it's still locked as intended.
** No other styling issues seen. Fix previous error and double check all tests still pass when harness is run.
|-
|<s>123</s>
|<s>file_unlockOnUnload.html</s>
|<s>northWind</s>
|
|
|
|X
|
|<s>rhung</s>
|
|<s>'''FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY'''</s>
|
|
|
|-
|<s>120</s>
|<s>file_differentDOM.html</s>
|<s>diogogmt</s>
|
|
|
|
|
|<s>rhung</s>
|
|<s>'''FIXED, PEER REVIEWED, AND ADDED TO REPOSITORY'''</s>
|
|
|
|-
|}
 
<!--
====Test Reviews[DEPRECATED]====
 
The following tests need review and/or fixes, and to then get updated in [https://github.com/rhung/mozilla-central/tree/mouselock-tests/dom/tests/mochitest/mouselock rhung's mouslock-tests] branch on github. Please add your name beside test(s) you are reviewing/fixing. Once a test is complete and updated in his branch, please cross it off below.
{| border=1 style="border: 1px solid darkgray;"
| Num
| Name
| Owner
| Has Harness
| Rev.
| Peer Rev.
| Pull
| Contrib.
|-
| colspan=8 bgcolor="yellow" style="text-align:center;" | '''Ensure you have actually tested your test before sending a pull request'''
|-
|-
| colspan=8 bgcolor="lightgreen" style="text-align:center;" | '''Fill Out the Contrib cell with "First Last <email>" or leave blank for none.'''
|-
|1
|test_FullScreenHarness.html
|Anachid
|X
|X
|humph
|X
|Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>
|-
|2
|mouselock_util.js
|Anachid
|X
|X
|humph
|X
|Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>
|-
|3
|file_DOMtree.html
|Anachid
|X
|X
|humph
|X
| Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>
|-
|4
|test_MouseEvents.html
|rhung
|X
|X
|jboelen
|X
|Raymond Hung <hung.raymond@gmail.com>
|-
|5
|test_TargetOutOfFocus.html
|johnno
|
|
|diogogmt
|
|
|-
|6
|test_UserAgentIsActive
|johnno
|
|
|diogogmt
|
|
|-
|7
|test_constantxy.html
|jbraffoul
|X
|X
|Anachid
|X
|Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>, Jordan Raffoul <raffoul.jordan@gmail.com>
|-
|8
|test_defaultUnlock.html
|KeyR
|X
|X
|nm486
|X
|Stanley Tsang <nm486@hotmail.com> Keyan Ren <rockyrky@hotmail.com>
|-
|9
|test_doubleLockCallBack.html
|jboelen
|
|X
|rhung
|
|James Boelen <james@boelen.ca>
|-
|10
|test_exitMouselockOnLoseFocus.html
|drigato / johnno
|
|
|diogogmt
|
|
|-
|11
|test_isInstanceofMouselockable.html
|abhatnagar
|N/A
|X
|hchun
|X
|Hyungryul Chun <hello.ryul@gmail.com>, Anurag Bhatnagar <bhatnagar.anurag@gmail.com>
|-
|12
|file_limitlessScroll.html
|hchun
|X
|X
|rhung, nm486
|X
|Hyungryul Chun <hello.ryul@gmail.com>, Stanley Tsang <nm486@hotmail.com>, Raymond Hung <hung.raymond@gmail.com>
|-
|13
|test_mouseLockableHasRequiredMethods.html
|abhatnagar
|N/A
|X
|hchun
|X
|Hyungryul Chun <hello.ryul@gmail.com>, Anurag Bhatnagar <bhatnagar.anurag@gmail.com>
|-
|14
|test_mousePos.html
|
|
|
|
|
|
|-
|15
|test_mouselocklost.html
|nm486
|X
|X
|hchun
|X
|Stanley Tsang <nm486@hotmail.com>, Hyungryul Chun (Steven) <hello.ryul@gmail.com>
|-
|16
|file_movement.html
|hchun
|X
|X
|rhung, nm486
|X
|Hyungryul Chun <hello.ryul@gmail.com>, Stanley Tsang <nm486@hotmail.com>, Raymond Hung <hung.raymond@gmail.com>
|-
|17
|test_navigatorPointer.html
|abhatnagar
|
|
|
|
|
|-
|18
|test_userPref.html
|mjschranz
|X
|X
|jboelen/rhung
|X
|Matthew Schranz <schranz.m@gmail.com>
|-
|19
|test_fullscreen.html
|abhatnagar1
|x
|x
|
|
|Abhishek Bhatnagar <abhatnagar1@learn.senecac.on.ca>
|-
|20
|test_syntheticMouseEvent.html
|Tentacle
|x
|x
|Anachid
|x
|Qian Xu <qxu26@learn.senecac.on.ca>, Ching Wei Tseng (Steven) <steven_tseng15@hotmail.com>
|}
 
 
'''[DEPRECATED]'''
# test_FullScreenHarness.html - Anachid
# mouselock_util.js - Anachid
# file_DOMtree.html - Anachid
# <s>test_LockWhenOutOfFocus.html</s> Note: Removed
# test_MouseEvents.html - rhung
# <s>test_TargetOutOfFocus.html</s> - johnno
# test_UserAgentIsActive.html - johnno
# test_constantxy.html - jbraffoul
# <s>test_defaultUnlock.html</s>
# <s>test_doesunlock.html</s> Note: Removed, redundant;
# <s>test_doubleLockCallBack.html</s>
# <s>test_exitMouselockOnLoseFocus.html</s> drigato,johnno(merged)
# <s>test_fullscreen.html</s>
# <s>test_isInstanceofMouselockable.html</s> - abhatnagar
# <s>test_limitlessScroll.html</s> - hchun
# <s>test_lockLostCallBack.html</s>
# <s>test_mouseLockableHasRequiredMethods.html</s> - abhatnagar
# test_mousePos.html
# <s>test_mouselocklost.html</s> - nm486
# <s>test_movement.html</s> -hchun
# <s>test_navigatorPointer.html</s> - abhatnagar
# <s>test_syntheticMouseEvent.html</s>
# <s>test_userPref.html</s> - mjschranz
-->
 
====Waiting For Focus====
Many tests will intermittently hang if they don't wait for focus. To have a test wait for focus, ensure that the test incorporates the following template:
<pre>
&lt;!-- snip --&gt;
&lt;body onload="runTests();"&gt;
 
&lt;!-- other tags that you may need go here --&gt;
 
&lt;script&gt;
function runTests() {
SimpleTest.waitForExplicitFinish();
SimpleTest.waitForFocus(function() {
 
// Test code goes here
 
});
}
&lt;/script&gt;
&lt;/body&gt;
&lt;!-- /snip --&gt;</pre>
 
 
 
====Using the Test Harness====
'''Note: This harness assumes that your test runs properly as a stand-alone application and is not being used as one of the test amongst others.'''
 
The problem with the test timing out is due to the fact that the Mochitest '''iframe does not allow fullscreen''' from the html code inside the frame. To solve this problem, it needs a small work around like using the harness.
 
To make use of the harness, you will need to add the '''mouselock_util.js''' file to your test html file. I would recommend renaming your file to '''file_something.html''' (vs. test_something.html), as this denotes that this not a direct test under the mochitest.
 
The same applies to the Makefile.in. '''Change the filename to their appropriate name in the Makefile.in'''
 
Thus, add the following line, AFTER the EventUtil.js and SimpleTest.js script tag
 
<pre>
<script type="application/javascript" src="mouselock_util.js"></script>
</pre>
 
Another, thing that needs to be done is to add your file to the '''gTestFiles''' array inside the '''test_FullScreenHarness.html''' file
 
After that, do a run of the whole mochitest directory on your machine before doing a pull request.
(use this):
<pre>
TEST_PATH=dom/tests/mochitest/mouselock/ make -C $(replace with OBJDIR) mochitest-plain
</pre>
 
 
Finally, since the fullscreen needs the harness, the harness will provide the special powers. So please do '''NOT add any special powers''' in your child files.
 
==Demos, Docs, Other==
 
# Proper IDL documentation for navigator.pointer (see example in https://mxr.mozilla.org/mozilla-central/source/dom/interfaces/html/nsIDOMHTMLElement.idl#103), MouseLockable and its methods, MouseLockLost event, etc.
# Write a JavaScript library to somehow combine element.mozRequestFullScreen() and navigator.pointer.lock(). It would be good to hide the complexities of doing fullscreen then locking in a single API call.
 
<pre>
var canvas = document.getElementById('canvas');
 
// Will put element into fullscreen then try to do mouse lock
var lock = acquireMouseLock({
element: canvas,
onLock: function() {
// OPTIONAL
// fullscreen + mouse lock are now setup for element
},
onUnlock: function() {
// OPTIONAL
// the user or browser took us out of fullscreen/mouse lock
},
onError: function() {
// OPTIONAL
// there was an error getting fullscreen/mouse lock
},
onMovemennt: function(e) {
// OPTIONAL
// movementX and movementY for mousemove are passed in
var deltaX = e.movementX;
var deltaY = e.movementY;
}
});
 
...
lock.islocked; // true or false
lock.unlock();
</pre>
 
# Mouse lock specification fix requests
# Convert Rescue Fox to use Mouse Lock, see https://github.com/mozilla/rescuefox
# <strike>Convert http://cjcliffe.github.com/CubicVR.js/cubicvr/samples/fps_demo/level1.html to use Mouse Lock</strike> - JSilver999
# Create a tutorial on how to use Mouse Lock, with code examples
# Add demo pages to [http://humphd.github.com/mozilla-central/mouselock/index.html gh-pages branch]
# Review https://developer.mozilla.org/en/API/Mouse_Lock_API for correctness with spec + our implementation
==Resources==
* WebKit Bug: https://bugs.webkit.org/show_bug.cgi?id=68468
* Chromium Bug: http://code.google.com/p/chromium/issues/detail?id=72754
* Points of Interest: http://zenit.senecac.on.ca/wiki/index.php/Mouse_Lock_API_Points_of_Interest
* Mochitest: https://developer.mozilla.org/en/Mochitest
* Mochitest FAQ: http://zenit.senecac.on.ca/wiki/index.php/Mochitest_FAQ
* Mozilla Cross Reference: http://mxr.mozilla.org/mozilla-central/
* MouseLock Demos Link: http://humphd.github.com/mozilla-central/mouselock/index.html
* MouseLock Stage Build download: http://stage.mozilla.org/pub/mozilla.org/firefox/try-builds/david.humphrey@senecac.on.ca-f4e5849f1ae7/
Diogogmt
1
edit
Retrieved from "https://wiki.cdot.senecapolytechnic.ca/wiki/Special:MobileDiff/73816...81425"