Difference between revisions of "PostgreSQL Adapter Project - Code Review 4 Changes"
(→PostgreSQLAdapter) |
(→PostgreSQLPreparedStatementProxy) |
||
Line 171: | Line 171: | ||
! Status | ! Status | ||
|- | |- | ||
− | |Provide a class comment | + | |*Provide a class comment |
− | + | *Prepend a comment "// inner classes" | |
− | + | *Use visibility declarators on members ("protected") | |
− | + | *Fold lines after about 110 chars | |
− | + | |'''DONE''' | |
− | |||
− | |||
− | |||
− | |||
− | |||
− | | | ||
|- | |- | ||
|requestSavepoint | |requestSavepoint | ||
Line 189: | Line 183: | ||
*The statement cleanup should be fixed. Right now it will not close the statement if an error occurs. | *The statement cleanup should be fixed. Right now it will not close the statement if an error occurs. | ||
| | | | ||
+ | * I think not, since the savepoints are only created inside a transaction block | ||
+ | * No, the driver does not allow setSavePoint on XA transaction (org.postgresql.xa.PGXAConnection) | ||
+ | *'''DONE''' | ||
+ | *'''DONE''' | ||
|} | |} | ||
Revision as of 16:54, 15 September 2011
Contents
General
Task | Status |
---|---|
{
} undo the change to ; |
Classes
Table
Task | Status |
---|---|
getQuotedName
|
DONE |
SQLAdapter
Task | Status |
---|---|
setQueryTimeout()
|
DONE |
CancelTask -> StatementCancelationTask;
|
DONE |
SQLSchemaManager
Task | Status |
---|---|
addColumn
|
DONE |
I think the portable flag should not take into account columns that are not added to the table (return null in this case)? | DONE |
The message about ignoring an index has changed
|
Diff is malfunctioning |
There are extensive changes to readSchema?
|
Diff is malfunctioning |
getAlterColumnToken
|
DONE |
isPortable()
This hampers method reusability.). |
DONE |
isWindowsCompatiable -> isWindowsCompatible | DONE |
StatementProxy/PreparedStatementProxy
Task | Status |
---|---|
*Proxy.java -> *Wrapper.java
|
DONE |
PostgreSQLAdapter
Task | Status |
---|---|
MAX_FIELD_PRECISION - is this from the PostgreSQL documentation?
|
DONE |
BIND_BLOB
You already have this value, no need to get it again later on. Use Primitive.createLong() to create the long value.
|
DONE'
|
BIND_STRING, BIND_BINARY
|
|
RequestTimeout should take into account non-positive timeouts. | values <=0 do not get to requestTimeout |
The timeout management functionality requestTimeout and releaseTimeout(rename to schedule and cancel)
|
DONE |
unwrap
|
- PGXADataSource is the one that gives pooled connections |
s_PGXAConnection, s_getQueryExecutor
|
-s_PGXAConnection used to ensure that reflected methods and properties loaded successfully |
appendIdentitySuffix
|
DONE |
appendLiteral
|
DONE
|
appendTypeConversion
|
DONE
|
indexNameMatches
|
DONE |
isUnicode
|
DONE |
PostgreSQLPreparedStatementProxy
Task | Status |
---|---|
*Provide a class comment
|
DONE |
requestSavepoint
|
|
PostgreSQLSchemaManager
Task | Status |
---|---|
appendColumnAlteration
|
|
appendLOManagerTrigger
|
|
appendTSIncrement
|
|
getGUIDExpr
|
|
isImplicitConversion
|
|
isValidColumnName
|
|
addColumn
|