Difference between revisions of "User:Rueen"

From CDOT Wiki
Jump to: navigation, search
 
(37 intermediate revisions by the same user not shown)
Line 8: Line 8:
  
 
== Projects/Assignments ==
 
== Projects/Assignments ==
*[http://zenit.senecac.on.ca/wiki/index.php/Localization_-_en-CA Automated Localization Build Tool] - we are in currently working on our 0.2 release and are anticipating completion of the release by the end of october. We plan to start the 0.3 release in November.
+
*[http://zenit.senecac.on.ca/wiki/index.php/Localization_-_en-CA Automated Localization Build Tool] - completed the 0.4 release. Moving the system toward an 1.0 release.
  
== Automated Localization Build Tool (0.1 Release) ==
+
== Open Source Project DPS911 ==
 +
* [http://zenit.senecac.on.ca/wiki/index.php/Localization_-_en-CA Automated Localization Build Tool]
 +
* I maintain the project's Wiki page as well as the project itself.
 +
 
 +
== Automated Localization Build Tool (Open Source project DPS909) ==
 
#Software Requirements: Python --> Get it from Python's [http://python.org/download/ download page]
 
#Software Requirements: Python --> Get it from Python's [http://python.org/download/ download page]
#Download the 0.1 release [https://bugzilla.mozilla.org/attachment.cgi?id=284789 here] (contains Python scripts and supporting DTD & Properties files).
+
#Project's [http://zenit.senecac.on.ca/wiki/index.php/Automated_localization_build_tool Wiki] provides information regarding the project and updated frequently.
#System's [http://matrix.senecac.on.ca/~azambran/mozilla/instructions0.1.txt instructions]. Basically, once you have Python installed, double click on the l10nMerge.py script and check the corresponding DTD and Properties files for the changes to the "color" string (which should now be called "colour")
+
#For more information, check out my [http://rueenfiez.wordpress.com/ blog].
#For more information, check out my [http://rueenfiez.wordpress.com/2007/10/20/01-release-for-automated-localization-build-tool/ blog] about the 0.1 release.
+
 
 +
== Contributions To Other Projects ==
 +
These are the following project's I've contributed to. Anything from actual code, documentation, testing, or providing some service to benefit the project.
 +
#'''Desktop Social Networking Integration project'''
 +
#'''Full Text History Search extension'''
 +
#'''Add Support For More Compilers To Distcc'''
 +
 
 +
=== Desktop Social Networking Integration ===
 +
*[http://zenit.senecac.on.ca/wiki/index.php/Desktop_Social_Networking_Integration Project's Wiki]
 +
*The project's leader, Timothy Duavis, was in need of a way to interface with his SQL Lite database. SQL Lite is essentially a mini-database that saves all data to a file. I found an SQL Lite client for him to use and showed him how to interact with it's functions to alter his database. I also provided him with professional contacts who are able to help him or any person using the SQL Lite database for open source project purposes.
 +
 
 +
=== Full Text History Search extension ===
 +
*[http://zenit.senecac.on.ca/wiki/index.php/Full-Text_History_Search_extension Project's Wiki]
 +
*I assisted the project's leader, Vijey Balasundaram, with JavaScript code primarily. As well as setting up his environment for actually building the extension
 +
 
 +
=== Add Support For More Compilers To Distcc ===
 +
*[http://zenit.senecac.on.ca/wiki/index.php/Add_support_for_more_compilers_to_distcc Project's Wiki]
 +
*I have lined up some C# files that need to be tested on the distcc compiler. They are not ordinary C# files, these are C# classes that include everything from data structures, use inheritance and polymorphism (in other words, interfaces). Peter Callaghan informed me that this would be beneficial to the project because it would test out if the system is capable of handling major C# systems.
 +
 
 +
== First XPCOM Lab ==
 +
This [http://zenit.senecac.on.ca/wiki/index.php/Real_World_Mozilla_First_XPCOM_Component lab] provided a walkthrough of how to create an XPCOM and subsequently utilize it. I learned a great deal about IDL files, creating make files, and how to create a basic XPCOM.
 +
[http://zenit.senecac.on.ca/wiki/index.php/Image:Xpcom_lab_rueen.JPG View Result Here]
 +
I also [http://rueenfiez.wordpress.com/2007/11/15/first-xpcom/ blogged] about my first XPCOM experience.
 +
 
 +
I've zipped up all important files to this lab. You can get the ZIP [http://zenit.senecac.on.ca/wiki/index.php/Image:XPCOM_Lab_Rueen.zip here].
 +
 
 +
 
 +
== XPCOM Lab II (XPCOM II - Using XPCOM from JS/Chrome) ==
 +
Here are the results from this lab.
 +
#[http://zenit.senecac.on.ca/wiki/index.php/Image:Lab5_1.JPG Screenshot #1 (The start)]
 +
#[http://zenit.senecac.on.ca/wiki/index.php/Image:Lab5_2.JPG Screenshot #2 (The result)]
 +
 
 +
 
 +
== Extending Browser (Creating .xpi) ==
 +
This lab showed us how to create an extension along with its .xpi file.
 +
*Lab's Resulting XPI file: [http://zenit.senecac.on.ca/wiki/imgs/Addtabbeside.xpi .xpi file]
 +
 
  
 
== Modifying Firefox Lab ==
 
== Modifying Firefox Lab ==
 +
Purpose of this lab was to modify the behavior of creating new Firefox tabs, specifically, their location. This patch will make tabs appear next to the current one instead of at the end of the tab list which is the default.
 +
 
<pre>
 
<pre>
 
Index: tabbrowser.xml
 
Index: tabbrowser.xml
Line 95: Line 137:
 
   
 
   
 
               this.mTabContainer.mTabstrip.scrollBoxObject
 
               this.mTabContainer.mTabstrip.scrollBoxObject
 +
 +
</pre>
 +
 +
== Thunderbird Hyperlink Bug Lab - Patch ==
 +
Thunderbird has a bug where it creates a hyperlink from message's text that didn't need to be a link. Further info about this bug is located on the [http://zenit.senecac.on.ca/wiki/index.php/Thunderbird_Bug_Fix_Lab lab page] as well as the bug I filed on landfill [http://landfill.bugzilla.org/bugzilla-3.0-branch/show_bug.cgi?id=6028 here]. Here is the patch that addresses this issue and fixes it.
 +
#Thunderbird hyperlink bug created on Bugzilla's [http://landfill.bugzilla.org/ Landfill] ---> [http://landfill.bugzilla.org/bugzilla-3.0-branch/show_bug.cgi?id=6028 Bug 6028]
 +
 +
<pre>
 +
? build2
 +
? thunderbird_lab_patch.txt
 +
? base/public/nsIStreamListenerProxy.idl
 +
? base/public/nsPIProtocolProxyService.idl
 +
? base/src/nsAsyncStreamListener.cpp
 +
? base/src/nsAsyncStreamListener.h
 +
? base/src/nsStreamListenerProxy.cpp
 +
? base/src/nsStreamListenerProxy.h
 +
? build/win32.order
 +
? cache/src/win32.order
 +
? cookie/public/nsICookieConsent.idl
 +
? protocol/about/src/nsAboutRedirector.cpp
 +
? protocol/about/src/nsAboutRedirector.h
 +
? protocol/data/public
 +
? protocol/file/src/nsFileProtocolModule.cpp
 +
? test/TestFileInput.cpp
 +
? test/TestFileTransport.cpp
 +
? test/TestWriteStream.cpp
 +
? test/unit/head.js
 +
? test/unit/head_http_server.js
 +
? test/unit/tail.js
 +
? test/unit/test_all.sh
 +
Index: streamconv/converters/mozTXTToHTMLConv.cpp
 +
===================================================================
 +
RCS file: /cvsroot/mozilla/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp,v
 +
retrieving revision 1.85
 +
diff -u -8 -p -r1.85 mozTXTToHTMLConv.cpp
 +
--- streamconv/converters/mozTXTToHTMLConv.cpp 11 Mar 2007 00:17:00 -0000 1.85
 +
+++ streamconv/converters/mozTXTToHTMLConv.cpp 8 Nov 2007 19:47:53 -0000
 +
@@ -181,17 +181,17 @@ mozTXTToHTMLConv::CompleteAbbreviatedURL
 +
  if (pos >= aInLength)
 +
    return;
 +
 +
  if (aInString[pos] == '@')
 +
  {
 +
    // only pre-pend a mailto url if the string contains a .domain in it..
 +
    //i.e. we want to linkify johndoe@foo.com but not "let's meet @8pm"
 +
    nsDependentString inString(aInString, aInLength);
 +
-    if (inString.FindChar('.', pos) != kNotFound) // if we have a '.' after the @ sign....
 +
+    if ((inString.FindChar('.', pos) != kNotFound) && (inString.Find("..", 0) == kNotFound)) // if we have a '.' after the @ sign....
 +
    {
 +
      aOutString.AssignLiteral("mailto:");
 +
      aOutString += aInString;
 +
    }
 +
  }
 +
  else if (aInString[pos] == '.')
 +
  {
 +
    if (ItMatchesDelimited(aInString, aInLength,
  
 
</pre>
 
</pre>
  
 
== FSOSS 2007 Report (DPS909) ==
 
== FSOSS 2007 Report (DPS909) ==
=== Introduction ===
+
[http://zenit.senecac.on.ca/wiki/index.php/User:Rueen/FSOSS_07_Report FSOSS: A Beginner's Perspective]
The main purpose of this report is to provide a concise summary of two presentations given at this year's Free Software and Open Source Symposium (FSOSS) as well as highlighting the speaker's view about open source and the surrounding communities in general. In addition, I'll be providing my own views about open source, it's supporting communities, and what I was able to take away from the presentations given at this year's FSOSS. This being my first FSOSS event, I was naturally overwhelmed and somewhat intimidated by all the “big-shots” in the world of open source. I went into this event with one goal in mind - to gain a better understanding of free software and open source and be able to apply what I learned when working on my own open source related projects.
 
=== Summary ===
 
I chose to attend the following two presentations because I believed – based on their brief description in the agenda page – that they would provide me with knowledge that I could put to use throughout the development of my own open source project. My own project in particular entails much code reading, code reuse, and is supported by a relatively large Firefox localization community. After much consideration, I knew that the following two presentations, as well as their respective speakers, would best complement my existing knowledge about code reading, code reuse, and developing for communities – while adding an open source “spin” on them. At the end of the event, I knew I had made the correct choice since much of what I learned has been applied to my existing open source project.
 
==== Code Reading and Review ====
 
Benjamin Smedberg's presentation outlined the reasons for reading code, difficulties encountered when reading code, code reading in a broader sense, and the different types of code review. He mentioned the various reasons why people read code which included – apart from it being an entertaining activity for “geeks” as he put it – fixing a bug, adding features, writing documentation, or just learning how a system works. Benjamin got down to the point and spoke about how code reading is hard especially when it comes to more complex systems. However, he emphasized that code in an open source context is '''not''' an individual activity and is in fact a '''social''' one. Code reading requires the participation of the code's author as well as the experts who contribute, maintain, or use the code extensively. The only exception to this rule would be if the system has no documentation, is relatively new, and the author of the code cannot be reached. The presentation also dived deeper into how to fix bugs by looking for common bad patterns such as “off-by-one” or “unsigned/signed mismatches”. I appreciated the advice he gave about mixing software frameworks together. Benjamin cautioned us that mixing frameworks, especially in JavaScript in particular, can lead to pitfalls in design and quality. In addition, Benjamin stressed that you do not have to understand the entire code, instead, you only need to understand the part of the code that concerns your end objective(s).
 
===== Background & Point of View (B.Smedberg) =====
 
Platform Guru is the official title given to Benjamin Smedberg which came as a surprise to me since I've never heard of such a thing and it seems quite unconventional. Although I shouldn't be surprised, I've been told that Mozilla is a unique corporation in many ways which just adds to its appeal. Benjamin's views on open source and its communities shouldn't be hard to guess, he emphasizes that open source as it relates to code reading and reviewing should be a '''collaborative endeavor'''. Not simply a lone coder sitting in a dark room straining his eyes over code they don't even understand – as Benjamin put it. The latter statement reflects well on the fact that programming in the open source world involves a lot of interaction with people you hardly know.
 
===== Thoughts About Code Reading and Reviewing in General =====
 
Based on what I have seen about open source so far, I believe that code reading is one of the most important skills a developer should be proficient at when working with the open source community. A developer who is able to read code and adapt it for their own purposes regardless of its complexity is able to employ a more versatile array of tools for each iteration. Code review has many benefits and applications, but personally, I perceive it as a skill necessary to deliver quality software to the community.
 
==== Product & User Experience Design in Open Communities ====
 
Mike Beltzner's presentation was focused on products and the user's experience with those products in an open community context. He essentially summed it up with his three “maxims”. The first being '''listening to your community''' which is basically focusing on what the community wants or needs. His second maxim was '''leading your community''' which is essentially to provide organization and structure to direct contributions from the community. Utilizing small focused teams is another approach to leading your community. Mike's final maxim is to '''allow the community to play and experiment''' with the product. Community feedback is extremely useful to ensure a higher quality of software. He also pointed out how Microsoft was making an effort to gather user's experience with their products by highlighting the “Happy face” and “Frown face” icons that appear in the task bar. Mike's presentation was filled useful information about relatively new software such as CoScripter and TheCoop. His presentation successfully influenced me enough to give these products a run and see what the hype is about. I'm happy to say that I found the experience very enlightening. The only thing that I was dissatisfied with was the fact that he didn't talk much about specific things the community looks for in a product but rather he mentioned ''ways of obtaining data'' regarding what communities think of a product.
 
===== Open Communities in Own Project =====
 
Since my own project involves working with an existing localization community I knew that Mike's presentation would give me more insight into how to work with them. The community in my own project is relatively large and is being led by a few Mozilla employees. They have been leading us with structure and organization by providing us with scripts, tools, contacts and possible approaches to reaching our main goals and objectives. In addition, we have also been following Mike's first maxim, listen to your community, by adding and removing features according to what we believe the community would want as well as their direct input through tools such as Bugzilla. Throughout the development of our project, we tried to keep our tool simple and not overly complex to use. We knew that if we made a complex tool, the community would simply reject it and the project would not progress any further in the future. With the help of Mozilla's Axel Hecht and Michal Berman (deeply involved in localization) and support from our professors Dave Humphrey and Chris Tyler - who have helped us considerably by providing us with strong guidance and contacts - we have been able to get our project off the ground and have built the foundation for a tool that the community can put to good use in the near future. We have also had a small taste of the some negative things from the open community. To put it briefly, our project is somewhat dependent on Python scripts and tools already built by Mozilla's localization team as well as the supporting community. Axel Hecht had recommended that we use a particular script to help with a specific feature in our system. For nearly a month and a half we tried to get in contact with the script's owner for information regarding the Python script. We finally got in touch - through Bugzilla - and are in the process of incorporating their tools with our new tool as recommended by Mozilla's localization team. Overall, we learned how to make due with the scripts we had and develop our system.
 
=== Views on Open Source ===
 
Both speakers primarily talked about open communities and how leading them can result in greater benefits for open source projects or existing open source products. Although both talks were about different topics, they had similarities when it came to how to manage and maintain an open community. Both talks also provided many tips and tricks on how to use specific products or follow certain methodologies.
 
==== Open Source Views From Code Reading and Review ====
 
Developers must take into account that when they are writing their code, they should be writing it in a way that will make it simple for another developer to come in an read it and understand it  in some ways. They can do this through documentation or other means to communicate the code and design decisions that were made throughout development. By making code easy to read, the authors can take advantage of the vast community that accompanies most open source projects by helping potential developers understand the code so they can attempt to contribute to it in some way. Also, its important for open communities to be able to read the code because most projects will have bugs. Often, the community is the one that will find these bugs and rectify them through patches. Developers must make an effort to make their code easy to read so communities can review the code without stopping at every class or method and asking “why do we need this?”. Open source communities also have a tendency to reuse existing code – something that I'm beginning to understand a great deal about. When you write code, there is always a possibility that your code may be used and adapted to someone else project. Proper documentation can make this adaption easier for the developer and increased the quality of the product.
 
==== Open Source Views From Product & User Experience Design ====
 
Mike Beltzner views the open source community like an unorganized and chaotic group of developers and enthusiasts who all want the product to add a new feature or remedy some bug. He sees the leadership's goal, Mozilla in this case, as turning this unorganized chaos into an organized chorus. He believes that as a result of turning chaos into a chorus, the product will benefit from it in the end. Mike is a strong believer in getting feedback from the community and allowing the community to express their ideas about a particular product. He believes that open source projects and existing open source products should have a streamlined way of getting community feedback, reporting bugs, and learning about the product in general. A good way of leading your community is to identify those who are making “smart” comments about a product then give them positive feedback so that they are more likely to contribute to the product in the future.
 
==== Comparison ====
 
Although Mike Beltzner and Benjamin Smedberg's presentations differed in terms of focus, they did however have one thing in common – how the open source community can impact a product. Benjamin's presentation focused more on how communities can fix bugs or add features to a product whereas Mike's presentation focused more on how to organize and maintain communities and harness their potential power to elevate products to a higher level of quality. Both speakers also centered their presentation around how communities should be led. Benjamin spoke about how code that is easily read can be reviewed more efficiently for potential contributors whereas Mike discussed how structure and organization can help lead communities. The only differences between the presentations was that Benjamin went more in depth into why code review by the community is beneficial and Mike talked more about creating a streamlined method of gathering user experience data and use that data to increase a product's quality.
 
=== Personal Views on Open Source & FSOSS ===
 
This being my first FSOSS, I did not have a clue the impact the speakers were going to have on me or even how much of the material presented I would actually put to practical use later on. Afterwards, I'd realized just how much FSOSS had impacted the way I perceive open source projects. In particular, Mike Beltzner's presentation was very informative and illustrated many useful systems I had no idea about such as CoScripter, TheCoop. He also reminded me of some others I'd forgotten about such as Miro, digg, Flickr, and many more. I hope future FSOSS events are as informative as this one.
 
==== Post-FSOSS Impact on Own Open Source Project(s) ====
 
After reflecting about what I learned during the FSOSS event, I was able to approach my own open source project from a whole new perspective. Looking through the myriad of localization tools – which is essentially a collection of Python scripts, XML files, DTD files, and Properties files – I was no longer intimidated when reading through its many classes and methods.  As a result of Benjamin Smedberg's presentation on code reading and review, I knew that to understand everything about the code is not necessary, and that I only need to understand specific parts of someone else's code and use them accordingly. Also, as a result of Mike Beltzner's presentation about open communities, I always kept in mind how the Firefox localization community would react to the design and programming decisions I make throughout the development of the project. Mike's emphasis on open communities made me realize how much I can help potential project contributors by highly documenting every part of my project. Everything from documentation in code, references to locations where code was reused, documentation related to product design, community contacts, and step-by-step processes. Not that I hadn't already documented, but Mike's presentation gave me incentives to document the project as much as I could for the sake of the community. I knew that by keeping the community in mind during the course of development, potential contributors would avoid common pitfalls when trying to read or reuse the code.
 
==== Recommendation ====
 
My first FSOSS experience was a positive one, filled with a lot of colorful and knowledgeable speakers. I was able to take away ''a lot'' of information from the presentations and successfully apply what I've learned to my own open source projects. I would definitely recommend going to next year's Free Software and Open Source Symposium to anyone – not just software developers – who even has a passing interest in open source applications, or is affected by the open source community in some way. It is a great way to meet the leaders in the community and learn new ways of approaching projects. Seeing their names in IRC channels, blog sites, or discussion groups and communicating with them through these mediums is one thing, whereas seeing them in person and getting the chance to talk to them face to face is another thing.
 
  
 
== Other ==
 
== Other ==

Latest revision as of 09:12, 20 January 2008

Profile

In the Bachelor of Software Development (BSD) program. Favorite Language: Java.

Name: Rueen Fiez
Email: rfiez-mo@learn.senecac.on.ca
Blog: Open Source blog

Projects/Assignments

Open Source Project DPS911

Automated Localization Build Tool (Open Source project DPS909)

  1. Software Requirements: Python --> Get it from Python's download page
  2. Project's Wiki provides information regarding the project and updated frequently.
  3. For more information, check out my blog.

Contributions To Other Projects

These are the following project's I've contributed to. Anything from actual code, documentation, testing, or providing some service to benefit the project.

  1. Desktop Social Networking Integration project
  2. Full Text History Search extension
  3. Add Support For More Compilers To Distcc

Desktop Social Networking Integration

  • Project's Wiki
  • The project's leader, Timothy Duavis, was in need of a way to interface with his SQL Lite database. SQL Lite is essentially a mini-database that saves all data to a file. I found an SQL Lite client for him to use and showed him how to interact with it's functions to alter his database. I also provided him with professional contacts who are able to help him or any person using the SQL Lite database for open source project purposes.

Full Text History Search extension

  • Project's Wiki
  • I assisted the project's leader, Vijey Balasundaram, with JavaScript code primarily. As well as setting up his environment for actually building the extension

Add Support For More Compilers To Distcc

  • Project's Wiki
  • I have lined up some C# files that need to be tested on the distcc compiler. They are not ordinary C# files, these are C# classes that include everything from data structures, use inheritance and polymorphism (in other words, interfaces). Peter Callaghan informed me that this would be beneficial to the project because it would test out if the system is capable of handling major C# systems.

First XPCOM Lab

This lab provided a walkthrough of how to create an XPCOM and subsequently utilize it. I learned a great deal about IDL files, creating make files, and how to create a basic XPCOM. View Result Here I also blogged about my first XPCOM experience.

I've zipped up all important files to this lab. You can get the ZIP here.


XPCOM Lab II (XPCOM II - Using XPCOM from JS/Chrome)

Here are the results from this lab.

  1. Screenshot #1 (The start)
  2. Screenshot #2 (The result)


Extending Browser (Creating .xpi)

This lab showed us how to create an extension along with its .xpi file.


Modifying Firefox Lab

Purpose of this lab was to modify the behavior of creating new Firefox tabs, specifically, their location. This patch will make tabs appear next to the current one instead of at the end of the tab list which is the default.

Index: tabbrowser.xml
===================================================================
RCS file: /cvsroot/mozilla/browser/base/content/tabbrowser.xml,v
retrieving revision 1.243
diff -u -8 -p -r1.243 tabbrowser.xml
--- tabbrowser.xml	18 Sep 2007 00:59:41 -0000	1.243
+++ tabbrowser.xml	15 Oct 2007 21:26:23 -0000
@@ -1073,32 +1073,41 @@
         <parameter name="aURI"/>
         <parameter name="aReferrerURI"/>
         <parameter name="aCharset"/>
         <parameter name="aPostData"/>
         <parameter name="aLoadInBackground"/>
         <parameter name="aAllowThirdPartyFixup"/>
         <body>
           <![CDATA[
+		  
+				
+			
+			
+			
+		  
             var bgLoad = (aLoadInBackground != null) ? aLoadInBackground :
                          this.mPrefs.getBoolPref("browser.tabs.loadInBackground");
             var owner = bgLoad ? null : this.selectedTab;
             var tab = this.addTab(aURI, aReferrerURI, aCharset, aPostData, owner,
                                   aAllowThirdPartyFixup);
             // Set newly selected tab after quick timeout, otherwise hideous focus problems
             // can occur when "browser.tabs.loadInBackground" is false and presshell is not ready
             if (!bgLoad) {
               function selectNewForegroundTab(browser, tab) {
                 browser.selectedTab = tab;
               }
               setTimeout(selectNewForegroundTab, 0, getBrowser(), tab);
             }
             if (!bgLoad)
               this.selectedTab = tab;
             
+			
+			var position = currentTabIndex + 1;
+			
             return tab;
          ]]>
         </body>
       </method>
 
       <method name="loadTabs">
         <parameter name="aURIs"/>
         <parameter name="aLoadInBackground"/>
@@ -1173,19 +1182,24 @@
             t.maxWidth = this.mTabContainer.mTabMaxWidth;
             t.minWidth = this.mTabContainer.mTabMinWidth;
             t.width = 0;
             t.setAttribute("flex", "100");
             t.setAttribute("validate", "never");
             t.setAttribute("onerror", "this.parentNode.parentNode.parentNode.parentNode.addToMissedIconCache(this.getAttribute('image')); this.removeAttribute('image');");
             t.className = "tabbrowser-tab";
 
-            this.mTabContainer.appendChild(t);
-
-            if (document.defaultView
+			
+			
+			var currentTabIndex = this.mTabContainer.selectedIndex;
+			this.mTabContainer.insertBefore(t, this.mTabContainer.childNodes.item(currentTabIndex + 1));
+			
+			
+			
+			if (document.defaultView
                         .getComputedStyle(this.mTabContainer, "")
                         .direction == "rtl") {
               /* In RTL UI, the tab is visually added to the left side of the
                * tabstrip. This means the tabstip has to be scrolled back in
                * order to make sure the same set of tabs is visible before and
                * after the new tab is added */
 
               this.mTabContainer.mTabstrip.scrollBoxObject

Thunderbird Hyperlink Bug Lab - Patch

Thunderbird has a bug where it creates a hyperlink from message's text that didn't need to be a link. Further info about this bug is located on the lab page as well as the bug I filed on landfill here. Here is the patch that addresses this issue and fixes it.

  1. Thunderbird hyperlink bug created on Bugzilla's Landfill ---> Bug 6028
? build2
? thunderbird_lab_patch.txt
? base/public/nsIStreamListenerProxy.idl
? base/public/nsPIProtocolProxyService.idl
? base/src/nsAsyncStreamListener.cpp
? base/src/nsAsyncStreamListener.h
? base/src/nsStreamListenerProxy.cpp
? base/src/nsStreamListenerProxy.h
? build/win32.order
? cache/src/win32.order
? cookie/public/nsICookieConsent.idl
? protocol/about/src/nsAboutRedirector.cpp
? protocol/about/src/nsAboutRedirector.h
? protocol/data/public
? protocol/file/src/nsFileProtocolModule.cpp
? test/TestFileInput.cpp
? test/TestFileTransport.cpp
? test/TestWriteStream.cpp
? test/unit/head.js
? test/unit/head_http_server.js
? test/unit/tail.js
? test/unit/test_all.sh
Index: streamconv/converters/mozTXTToHTMLConv.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp,v
retrieving revision 1.85
diff -u -8 -p -r1.85 mozTXTToHTMLConv.cpp
--- streamconv/converters/mozTXTToHTMLConv.cpp	11 Mar 2007 00:17:00 -0000	1.85
+++ streamconv/converters/mozTXTToHTMLConv.cpp	8 Nov 2007 19:47:53 -0000
@@ -181,17 +181,17 @@ mozTXTToHTMLConv::CompleteAbbreviatedURL
   if (pos >= aInLength)
     return;
 
   if (aInString[pos] == '@')
   {
     // only pre-pend a mailto url if the string contains a .domain in it..
     //i.e. we want to linkify johndoe@foo.com but not "let's meet @8pm"
     nsDependentString inString(aInString, aInLength);
-    if (inString.FindChar('.', pos) != kNotFound) // if we have a '.' after the @ sign....
+    if ((inString.FindChar('.', pos) != kNotFound) && (inString.Find("..", 0) == kNotFound)) // if we have a '.' after the @ sign....
     {
       aOutString.AssignLiteral("mailto:");
       aOutString += aInString;
     }
   }
   else if (aInString[pos] == '.')
   {
     if (ItMatchesDelimited(aInString, aInLength,

FSOSS 2007 Report (DPS909)

FSOSS: A Beginner's Perspective

Other

External Links

DPS909