Difference between revisions of "LukasBlakkTBBugFixLab"
Backinblakk (talk | contribs) (→Fixing the problem) |
Backinblakk (talk | contribs) (→Creating a patch) |
||
| Line 14: | Line 14: | ||
== Creating a patch == | == Creating a patch == | ||
| + | This is easily done by calling cvs diff -u8p . > mailtoPatch.txt in my mozilla directory. | ||
== Requesting Review == | == Requesting Review == | ||
== Results of Review == | == Results of Review == | ||
Revision as of 20:29, 8 November 2007
This the page where I will document my results of doing the Thunderbird_Bug_Fix_Lab
Contents
Filing a bug
First I had to create a bug over on landfill - explaining the issue
The gist is that anything that has characters@...Someothercharacters turns into a mailto: link in Thunderbird and this was annoying Dave so the whole class jumped to fix it.
Fixing the problem
Dowloaded and built a copy of Thunderbird's trunk on my MacBook and then navigated over to mozTXTToHTMLConv.cpp in order to alter some code which checks for a '.' after the @ symbol but does not also check that there is not a ".." in that string.
This is a one-line fix but I was having some trouble getting my code changes to show up. Funny story, this happened to me in class too and both times it was because I forgot a ) in the code.
Creating a patch
This is easily done by calling cvs diff -u8p . > mailtoPatch.txt in my mozilla directory.
