19
edits
Changes
→8. Submission
=Fixing a Bug, Adding Tests=
This week we're looking at the [https://brave.com/ Brave browser]. We spent time working through a [https://github.com/humphd/browser-laptop/tree/good-first-experience-issue-10554#walkthrough-fixing-a-bug-in-the-brave-browser walkthrough of a bug fix] together. Now it's your turn to try and fix a bug and add more tests.
In this lab, you are asked to fix a bug in Brave using [http://agiledata.org/essays/tdd.html Test Driven Development (TDD)]. With TDD, we write tests '''before''' we implement the code, and work toward getting our tests to pass. The goals of the lab include:
==4. Compare Implementations==
Sometimes it's helpful to compare how two different projects implement the same feature. You can often learn a lot by reading the code in a project that does what you want, in order to make another do new things.
We'll compare the code for Firefox, Chrome, and Brave:
* The equivalent code in Chrome is also written in C++, see https://cs.chromium.org/chromium/src/components/url_formatter/url_fixer.cc and https://cs.chromium.org/chromium/src/components/url_formatter/url_fixer.h
Read through both files and try to orient yourself. Don't get hung-up on understanding every single line, especially in the Firefox C++ code, which uses lots of internal string APIs and , [https://en.wikipedia.org/wiki/XPCOM XPCOM base code], etc. Instead, try to find clues as to how each one is doing what it does with input strings before converting them to URLs.
==5. Add Test Cases==
|-
| 1
|Yalong Li|https://github.com/yalooong/browser-laptop/commit/d73de8762d853408294501d134cd5966ad232137|https://yalongxyz.blogspot.ca/2018/04/osd-lab6-blog-post.html
|-
| 2
|Matthew Quan|https://github.com/AlexWang-16/browser-laptop/commit/64526635e6e39e1dbadbf915e0010f8465170285|https://mattprogrammingblog.wordpress.com/2018/04/07/osd600-lab-6-fixing-a-bug-in-brave/
|-
| 3
|Kelvin Cho|https://github.com/TheKinshu/browser-laptop/commit/dbc7a32f04fb282691f42452e5e765faaaa5068f|https://klvincho.wordpress.com/2018/04/08/osd600-lab6/
|-
| 4
|Joseph Pham|https://github.com/jpham14/browser-laptop/commit/628fe2914f5d20b3062db457249a5ff514d610d4|https://jpham14.wordpress.com/2018/04/09/lab-6-brave-browser-bug/
|-
| 5
|Owen Mak|https://github.com/Owen-Mak/browser-laptop/commit/02ac6dc499b68cfc8e7864d6a641d1ca36bbc564|https://makowen.wordpress.com/2018/04/12/brave-url-testing/
|-
| 6
|Lucas Verbeke|https://github.com/Micluc/browser-laptop/commit/75f6e90f17f5a8bb096d70b60618832d3061b1d5|https://thelucasexcerpt.wordpress.com/2018/04/12/osd600-lab-6-lucas-verbeke
|-
| 7
|Hao Chen|https://github.com/haoRchen/browser-laptop/commit/7508291fb97050caaf714e8de6b4224d6eb87e55|https://medium.com/haorc/tdd-in-brave-browser-6cdf5162729c
|-
| 8
|Qiliang Chen|https://github.com/KignorChan/browser-laptop/compare/translate-zh-CH...fix-url?diff=unified&name=fix-url|https://qchen102.blogspot.ca/2018/04/osd600-lab-6-fixing-url-bug-in-brave.html
|-
| 9
|Hongcheng Zhang|https://github.com/brave/browser-laptop/compare/master...StevenZhang123:browser-laptop|https://hongcheng1993.wordpress.com/2018/04/15/lab6/
|-
| 10
|Alex Wang|https://github.com/AlexWang-16/browser-laptop/commit/64526635e6e39e1dbadbf915e0010f8465170285|https://alexopensource.wordpress.com/2018/04/05/fix-url-issues-with-brave-browser-using-test-driven-development/
|-
| 11
|Soutrik Barua|https://github.com/buttersnipps/browser-laptop/commit/00f4a3fde46d4173ba1c06b90ce62536161951a3|http://soutrikbarua.blogspot.ca/2018/04/fixing-url-bug-in-brave.html
|-
| 12
|Abdul Kabia|https://github.com/AbdulKabia/browser-laptop/commit/28caa8563b86b122caa70970d9741cf8f5ca38cd|https://akkabia.wordpress.com/2018/04/15/show-me-dog-cat-pictures/
|-
| 13
|Zukhruf Khan|https://github.com/zeddkay/browser-laptop/commit/dbd2ddd869c5fc38ee44a25545f4ae153ed6dab8|https://zedsdps909blog.wordpress.com/2018/04/16/fixing-a-bug-adding-tests/
|-
| 14
|Vimal Raghubir|https://github.com/Vimal-Raghubir/browser-laptop/commit/32cb08efbb5021e1dbdaa494d76c2d4370913a34|https://medium.com/@vraghubir/brave-browser-bug-fix-eae6ad5b9c23
|-
| 15
|Oleh Hodovaniuk|https://github.com/ohodovaniuk1/browser-laptop/commit/2f41d18cd0b6defaf349d8c859447a1c668f3929|https://ohodovaniuk.wordpress.com/2018/04/07/osd600-lab6/
|-
| 16
|Patrick Godbout|https://github.com/Owen-Mak/browser-laptop/commit/02ac6dc499b68cfc8e7864d6a641d1ca36bbc564|https://mb30myopensourceblog.blogspot.ca/2018/04/fixing-bug-adding-tests.html
|-
| 17
|Pranoy Santosh|https://github.com/pranoy10/browser-laptop/commit/1d8d4c08f06ab05d10b0d98e9b3b699e0934af5e|http://pranoydps909.blogspot.ca/2018/04/brave-browser-bug-fix.html
|-
| 18
|Kevin Pham|https://github.com/pranoy10/browser-laptop/commit/1d8d4c08f06ab05d10b0d98e9b3b699e0934af5e|http://kqpham2.blogspot.ca/2018/04/brave-browser.html
|-
| 19
|Michael Fainshtein|https://github.com/mfainshtein2/browser-laptop/tree/lab6|https://moderatelyokaydeveloper.wordpress.com/2018/04/21/file-url-we-need-some-space/
|-
| 20
|Woodson Delhia|https://github.com/AlexWang-16/browser-laptop/commit/64526635e6e39e1dbadbf915e0010f8465170285|https://woodsondelhia.wordpress.com/2018/04/24/lab-6-brave-browser
|-
| 21
|Justin Vuu|https://github.com/jevuu/browser-laptop/commit/7bec15a0ca258c73d6877e569c72f4b6d143546a|https://justosd.wordpress.com/2018/04/23/osd600-lab-6-fixing-a-bug-and-adding-tests/
|-
| 22
|Bakytzhan Apetov|https://github.com/apetov/browser-laptop/commit/420bfa5076bfc0477dd006af2ddef7f1d56e4508|https://bapetov.wordpress.com/2018/04/23/lab-6-fixing-white-space-search/
|-
| 23
|Zhihao Cai|https://github.com/josechoy/browser-laptop/commit/fa607bd5e8f3bb2cee4bc00dda58c83f68bdbff5|https://choyzhihao.wordpress.com/2018/04/23/tdd-practice-in-brave/
|-
| 24
|Aleksey Glazkov|https://github.com/alexglazkov9/browser-laptop/commit/39d2db37cb403adc264abbdf01a820dd376da26b|https://aglazkovblog.wordpress.com/2018/04/29/dps909-lab-6/
|-
| 25